Ignore:
Timestamp:
Oct 31, 2017, 1:29:55 PM (8 years ago)
Author:
[email protected]
Message:

StructureStubInfo should have GPRReg members not int8_ts
https://bugs.webkit.org/show_bug.cgi?id=179071

Reviewed by Michael Saboff.

This patch makes the various RegisterID enums be backed by
uint8_t. This means that we can remove the old int8_t members in
StructureStubInfo and replace them with the correct enum types.

Also, this fixes an indentation issue in ARMv7Assembler.h.

  • assembler/ARM64Assembler.h:
  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:

(JSC::ARMRegisters::asSingle):
(JSC::ARMRegisters::asDouble):

  • assembler/MIPSAssembler.h:
  • assembler/X86Assembler.h:
  • bytecode/InlineAccess.cpp:

(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::getScratchRegister):

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::valueRegs const):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileIn):

  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r224236 r224243  
     12017-10-31  Keith Miller  <[email protected]>
     2
     3        StructureStubInfo should have GPRReg members not int8_ts
     4        https://bugs.webkit.org/show_bug.cgi?id=179071
     5
     6        Reviewed by Michael Saboff.
     7
     8        This patch makes the various RegisterID enums be backed by
     9        uint8_t. This means that we can remove the old int8_t members in
     10        StructureStubInfo and replace them with the correct enum types.
     11
     12        Also, this fixes an indentation issue in ARMv7Assembler.h.
     13
     14        * assembler/ARM64Assembler.h:
     15        * assembler/ARMAssembler.h:
     16        * assembler/ARMv7Assembler.h:
     17        (JSC::ARMRegisters::asSingle):
     18        (JSC::ARMRegisters::asDouble):
     19        * assembler/MIPSAssembler.h:
     20        * assembler/X86Assembler.h:
     21        * bytecode/InlineAccess.cpp:
     22        (JSC::InlineAccess::generateSelfPropertyAccess):
     23        (JSC::getScratchRegister):
     24        * bytecode/PolymorphicAccess.cpp:
     25        (JSC::PolymorphicAccess::regenerate):
     26        * bytecode/StructureStubInfo.h:
     27        (JSC::StructureStubInfo::valueRegs const):
     28        * dfg/DFGSpeculativeJIT.cpp:
     29        (JSC::DFG::SpeculativeJIT::compileIn):
     30        * ftl/FTLLowerDFGToB3.cpp:
     31        (JSC::FTL::DFG::LowerDFGToB3::compileIn):
     32        * jit/JITInlineCacheGenerator.cpp:
     33        (JSC::JITByIdGenerator::JITByIdGenerator):
     34        (JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
     35
    1362017-10-31  Devin Rousso  <[email protected]>
    237
Note: See TracChangeset for help on using the changeset viewer.