Changeset 224243 in webkit for trunk/Source/JavaScriptCore/bytecode/InlineAccess.cpp

Timestamp:

Oct 31, 2017, 1:29:55 PM (8 years ago)

Author:

[email protected]

Message:

StructureStubInfo should have GPRReg members not int8_ts
​https://bugs.webkit.org/show_bug.cgi?id=179071

Reviewed by Michael Saboff.

This patch makes the various RegisterID enums be backed by
uint8_t. This means that we can remove the old int8_t members in
StructureStubInfo and replace them with the correct enum types.

Also, this fixes an indentation issue in ARMv7Assembler.h.

• assembler/ARM64Assembler.h:
• assembler/ARMAssembler.h:
• assembler/ARMv7Assembler.h:

(JSC::ARMRegisters::asSingle):
(JSC::ARMRegisters::asDouble):

• assembler/MIPSAssembler.h:
• assembler/X86Assembler.h:
• bytecode/InlineAccess.cpp:

(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::getScratchRegister):

• bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

• bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::valueRegs const):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileIn):

• jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):

File:

• trunk/Source/JavaScriptCore/bytecode/InlineAccess.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/bytecode/InlineAccess.cpp

@@ -162 +162 @@
     CCallHelpers jit;
     
-    GPRReg base = static_cast<GPRReg>(stubInfo.patch.baseGPR);
+    GPRReg base = stubInfo.patch.baseGPR;
     JSValueRegs value = stubInfo.valueRegs();
 
@@ -190 +190 @@
 {
     ScratchRegisterAllocator allocator(stubInfo.patch.usedRegisters);
-    allocator.lock(static_cast<GPRReg>(stubInfo.patch.baseGPR));
-    allocator.lock(static_cast<GPRReg>(stubInfo.patch.valueGPR));
+    allocator.lock(stubInfo.patch.baseGPR);
+    allocator.lock(stubInfo.patch.valueGPR);
 #if USE(JSVALUE32_64)
-    allocator.lock(static_cast<GPRReg>(stubInfo.patch.baseTagGPR));
-    allocator.lock(static_cast<GPRReg>(stubInfo.patch.valueTagGPR));
+    allocator.lock(stubInfo.patch.baseTagGPR);
+    allocator.lock(stubInfo.patch.valueTagGPR);
 #endif
     GPRReg scratch = allocator.allocateScratchGPR();