Changeset 224258 in webkit for trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

Timestamp:

Oct 31, 2017, 4:12:32 PM (8 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r224243, r224246, and r224248.
​https://bugs.webkit.org/show_bug.cgi?id=179083

The patch and fix broke the Windows build. (Requested by
mlewis13 on #webkit).

Reverted changesets:

"StructureStubInfo should have GPRReg members not int8_ts"
​https://bugs.webkit.org/show_bug.cgi?id=179071
​https://trac.webkit.org/changeset/224243

"Make all register enums be backed by uint8_t."
​https://bugs.webkit.org/show_bug.cgi?id=179074
​https://trac.webkit.org/changeset/224246

"Unreviewed, windows build fix."
​https://trac.webkit.org/changeset/224248

File:

• trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

@@ -1051 +1051 @@
             stubInfo->callSiteIndex = m_jit.addCallSite(node->origin.semantic);
             stubInfo->codeOrigin = node->origin.semantic;
-            stubInfo->patch.baseGPR = baseGPR;
-            stubInfo->patch.valueGPR = resultGPR;
-            stubInfo->patch.thisGPR = InvalidGPRReg;
+            stubInfo->patch.baseGPR = static_cast<int8_t>(baseGPR);
+            stubInfo->patch.valueGPR = static_cast<int8_t>(resultGPR);
+            stubInfo->patch.thisGPR = static_cast<int8_t>(InvalidGPRReg);
 #if USE(JSVALUE32_64)
-            stubInfo->patch.valueTagGPR = InvalidGPRReg;
-            stubInfo->patch.baseTagGPR = InvalidGPRReg;
-            stubInfo->patch.thisTagGPR = InvalidGPRReg;
+            stubInfo->patch.valueTagGPR = static_cast<int8_t>(InvalidGPRReg);
+            stubInfo->patch.baseTagGPR = static_cast<int8_t>(InvalidGPRReg);
+            stubInfo->patch.thisTagGPR = static_cast<int8_t>(InvalidGPRReg);
 #endif
             stubInfo->patch.usedRegisters = usedRegisters();