Changeset 225286 in webkit for trunk/Source/JavaScriptCore/assembler/testmasm.cpp

Timestamp:

Nov 29, 2017, 12:12:32 PM (8 years ago)

Author:

[email protected]

Message:

Source/JavaScriptCore:
[MIPS][JSC] Implement MacroAssembler::probe support on MIPS
​https://bugs.webkit.org/show_bug.cgi?id=175447

Patch by Stanislav Ocovaj <​[email protected]> on 2017-11-29
Reviewed by Carlos Alberto Lopez Perez.

This patch allows DFG JIT to be enabled on MIPS platforms.

• Sources.txt:
• assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::lastSPRegister):
(JSC::MIPSAssembler::numberOfSPRegisters):
(JSC::MIPSAssembler::sprName):

• assembler/MacroAssemblerMIPS.cpp: Added.

(JSC::MacroAssembler::probe):

• assembler/ProbeContext.cpp:

(JSC::Probe::executeProbe):

• assembler/ProbeContext.h:

(JSC::Probe::CPUState::pc):

• assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):

Source/WTF:
[DFG][MIPS] Enable DFG JIT on MIPS.
​https://bugs.webkit.org/show_bug.cgi?id=175447

Patch by Stanislav Ocovaj <​[email protected]> on 2017-11-29
Reviewed by Carlos Alberto Lopez Perez.

• wtf/Platform.h:

File:

• trunk/Source/JavaScriptCore/assembler/testmasm.cpp (modified) (11 diffs, 1 prop)

trunk/Source/JavaScriptCore/assembler/testmasm.cpp

@@ -136 +136 @@
     if (id == ARM64Registers::x18)
         return true;
+#elif CPU(MIPS)
+    if (id == MIPSRegisters::zero || id == MIPSRegisters::k0 || id == MIPSRegisters::k1)
+        return true;
 #endif
     return false;
@@ -401 +404 @@
             }
             for (auto id = CCallHelpers::firstFPRegister(); id <= CCallHelpers::lastFPRegister(); id = nextID(id))
+#if CPU(MIPS)
+                if (!(id & 1))
+#endif
                 CHECK_EQ(cpu.fpr<uint64_t>(id), testWord64(id));
         });
@@ -427 +433 @@
             }
             for (auto id = CCallHelpers::firstFPRegister(); id <= CCallHelpers::lastFPRegister(); id = nextID(id))
+#if CPU(MIPS)
+                if (!(id & 1))
+#endif
                 CHECK_EQ(cpu.fpr<uint64_t>(id), originalState.fpr<uint64_t>(id));
         });
@@ -442 +451 @@
     void* originalSP { nullptr };
     void* modifiedSP { nullptr };
+#if !(CPU(MIPS))
     uintptr_t modifiedFlags { 0 };
+#endif
     
 #if CPU(X86) || CPU(X86_64)
@@ -474 +485 @@
             }
 
+#if !(CPU(MIPS))
             originalState.spr(flagsSPR) = cpu.spr(flagsSPR);
             modifiedFlags = originalState.spr(flagsSPR) ^ flagsMask;
             cpu.spr(flagsSPR) = modifiedFlags;
+#endif
 
             originalSP = cpu.sp();
@@ -497 +510 @@
             }
             for (auto id = CCallHelpers::firstFPRegister(); id <= CCallHelpers::lastFPRegister(); id = nextID(id))
+#if CPU(MIPS)
+                if (!(id & 1))
+#endif
                 CHECK_EQ(cpu.fpr<uint64_t>(id), testWord64(id));
+#if !(CPU(MIPS))
             CHECK_EQ(cpu.spr(flagsSPR) & flagsMask, modifiedFlags & flagsMask);
+#endif
             CHECK_EQ(cpu.sp(), modifiedSP);
         });
@@ -513 +531 @@
             for (auto id = CCallHelpers::firstFPRegister(); id <= CCallHelpers::lastFPRegister(); id = nextID(id))
                 cpu.fpr(id) = originalState.fpr(id);
+#if !(CPU(MIPS))
             cpu.spr(flagsSPR) = originalState.spr(flagsSPR);
+#endif
             cpu.sp() = originalSP;
         });
@@ -527 +547 @@
             }
             for (auto id = CCallHelpers::firstFPRegister(); id <= CCallHelpers::lastFPRegister(); id = nextID(id))
+#if CPU(MIPS)
+                if (!(id & 1))
+#endif
                 CHECK_EQ(cpu.fpr<uint64_t>(id), originalState.fpr<uint64_t>(id));
+#if !(CPU(MIPS))
             CHECK_EQ(cpu.spr(flagsSPR) & flagsMask, originalState.spr(flagsSPR) & flagsMask);
+#endif
             CHECK_EQ(cpu.sp(), originalSP);
         });
@@ -641 +666 @@
                 cpu.fpr(id) = bitwise_cast<double>(testWord64(id));
             }
+#if !(CPU(MIPS))
             originalState.spr(flagsSPR) = cpu.spr(flagsSPR);
             modifiedFlags = originalState.spr(flagsSPR) ^ flagsMask;
             cpu.spr(flagsSPR) = modifiedFlags;
+#endif
 
             // Ensure that we'll be writing over the regions of the stack where the Probe::State is.
@@ -677 +704 @@
             }
             for (auto id = CCallHelpers::firstFPRegister(); id <= CCallHelpers::lastFPRegister(); id = nextID(id))
+#if CPU(MIPS)
+                if (!(id & 1))
+#endif
                 CHECK_EQ(cpu.fpr<uint64_t>(id), testWord64(id));
+#if !(CPU(MIPS))
             CHECK_EQ(cpu.spr(flagsSPR) & flagsMask, modifiedFlags & flagsMask);
+#endif
             CHECK_EQ(cpu.sp(), newSP);
 
@@ -702 +734 @@
             for (auto id = CCallHelpers::firstFPRegister(); id <= CCallHelpers::lastFPRegister(); id = nextID(id))
                 cpu.fpr(id) = originalState.fpr(id);
+#if !(CPU(MIPS))
             cpu.spr(flagsSPR) = originalState.spr(flagsSPR);
+#endif
             cpu.sp() = originalSP;
         });