Changeset 225519 in webkit for trunk/Source/JavaScriptCore/runtime/MathObject.cpp

Timestamp:

Dec 4, 2017, 11:51:33 PM (7 years ago)

Author:

[email protected]

Message:

Math: don't redundantly check for exceptions, just release scope
​https://bugs.webkit.org/show_bug.cgi?id=180395

Rubber stamped by Mark Lam.

Two of the exceptions checks could just have been exception scope
releases before the return, which is ever-so-slightly more
efficient. The same technically applies where we have loops over
parameters, but doing the scope release there isn't really more
efficient and is way harder to read.

• runtime/MathObject.cpp:

(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncPow):

File:

• trunk/Source/JavaScriptCore/runtime/MathObject.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/MathObject.cpp

@@ -154 +154 @@
     double arg0 = exec->argument(0).toNumber(exec);
     RETURN_IF_EXCEPTION(scope, encodedJSValue());
+    scope.release();
     double arg1 = exec->argument(1).toNumber(exec);
-    RETURN_IF_EXCEPTION(scope, encodedJSValue());
     return JSValue::encode(jsDoubleNumber(atan2(arg0, arg1)));
 }
@@ -266 +266 @@
     double arg = exec->argument(0).toNumber(exec);
     RETURN_IF_EXCEPTION(scope, encodedJSValue());
+    scope.release();
     double arg2 = exec->argument(1).toNumber(exec);
-    RETURN_IF_EXCEPTION(scope, encodedJSValue());
 
     return JSValue::encode(JSValue(operationMathPow(arg, arg2)));