Changeset 2262 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 6, 2002, 3:17:41 PM (23 years ago)

Author:

darin

Message:

I noticed some broken lists at mapblast.com and tracked it down to this.

• kjs/array_object.cpp: (ArrayInstanceImp::put): Don't truncate the list; only extend the length if it's not already long enough. (ArrayProtoFuncImp::call): Fix some ifdef'd code so it compiles if you turn the ifdefs on.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ChangeLog-2002-12-03 (modified) (1 diff)
• ChangeLog-2003-10-25 (modified) (1 diff)
• kjs/array_object.cpp (modified) (4 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2002-10-06  Darin Adler  <[email protected]>
+
+        I noticed some broken lists at mapblast.com and tracked it down to this.
+
+        * kjs/array_object.cpp:
+        (ArrayInstanceImp::put): Don't truncate the list; only extend the length if
+        it's not already long enough.
+        (ArrayProtoFuncImp::call): Fix some ifdef'd code so it compiles if you turn
+        the ifdefs on.
+
 2002-10-04  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2002-12-03

@@ +1 @@
+2002-10-06  Darin Adler  <[email protected]>
+
+        I noticed some broken lists at mapblast.com and tracked it down to this.
+
+        * kjs/array_object.cpp:
+        (ArrayInstanceImp::put): Don't truncate the list; only extend the length if
+        it's not already long enough.
+        (ArrayProtoFuncImp::call): Fix some ifdef'd code so it compiles if you turn
+        the ifdefs on.
+
 2002-10-04  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2003-10-25

@@ +1 @@
+2002-10-06  Darin Adler  <[email protected]>
+
+        I noticed some broken lists at mapblast.com and tracked it down to this.
+
+        * kjs/array_object.cpp:
+        (ArrayInstanceImp::put): Don't truncate the list; only extend the length if
+        it's not already long enough.
+        (ArrayProtoFuncImp::call): Fix some ifdef'd code so it compiles if you turn
+        the ifdefs on.
+
 2002-10-04  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -102 +102 @@
   unsigned index = propertyName.toULong(&ok);
   if (ok) {
-    setLength(index + 1);
+    if (length <= index)
+      setLength(index + 1);
     storage[index] = value.imp();
     return;
@@ -112 +113 @@
 void ArrayInstanceImp::put(ExecState *exec, unsigned index, const Value &value, int attr)
 {
-  setLength(index + 1);
+  if (length <= index)
+    setLength(index + 1);
   storage[index] = value.imp();
 }
@@ -412 +414 @@
     printf("KJS Array::Sort length=%d\n", length);
     for ( unsigned int i = 0 ; i<length ; ++i )
-      printf("KJS Array::Sort: %d: %s\n", i, thisObj.get(i).toString().value().ascii() );
+      printf("KJS Array::Sort: %d: %s\n", i, thisObj.get(exec, i).toString(exec).ascii() );
 #endif
     Object sortFunction;
@@ -470 +472 @@
     printf("KJS Array::Sort -- Resulting array:\n");
     for ( unsigned int i = 0 ; i<length ; ++i )
-      printf("KJS Array::Sort: %d: %s\n", i, thisObj.get(i).toString().value().ascii() );
+      printf("KJS Array::Sort: %d: %s\n", i, thisObj.get(exec, i).toString(exec).ascii() );
 #endif
     result = thisObj;