Changeset 2267 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 7, 2002, 2:06:29 PM (23 years ago)

Author:

darin

Message:

Fixed absurdly high memory usage when looking at pages that use a lot of JavaScript.

• kjs/collector.cpp: (Collector::allocate): Implement a new policy of doing a garbage collect every 1000 allocations. The old policy was both complicated and misguided. (Collector::collect): Zero out the "number of allocations since last collect".

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ChangeLog-2002-12-03 (modified) (1 diff)
• ChangeLog-2003-10-25 (modified) (1 diff)
• kjs/collector.cpp (modified) (4 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2002-10-07  Darin Adler  <[email protected]>
+
+        Fixed absurdly high memory usage when looking at pages that use a lot of JavaScript.
+
+        * kjs/collector.cpp:
+        (Collector::allocate): Implement a new policy of doing a garbage collect every 1000
+        allocations. The old policy was both complicated and misguided.
+        (Collector::collect): Zero out the "number of allocations since last collect".
+
 2002-10-06  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2002-12-03

@@ +1 @@
+2002-10-07  Darin Adler  <[email protected]>
+
+        Fixed absurdly high memory usage when looking at pages that use a lot of JavaScript.
+
+        * kjs/collector.cpp:
+        (Collector::allocate): Implement a new policy of doing a garbage collect every 1000
+        allocations. The old policy was both complicated and misguided.
+        (Collector::collect): Zero out the "number of allocations since last collect".
+
 2002-10-06  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2003-10-25

@@ +1 @@
+2002-10-07  Darin Adler  <[email protected]>
+
+        Fixed absurdly high memory usage when looking at pages that use a lot of JavaScript.
+
+        * kjs/collector.cpp:
+        (Collector::allocate): Implement a new policy of doing a garbage collect every 1000
+        allocations. The old policy was both complicated and misguided.
+        (Collector::collect): Zero out the "number of allocations since last collect".
+
 2002-10-06  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/kjs/collector.cpp

@@ -84 +84 @@
 #endif
 
+#if APPLE_CHANGES
+static int numAllocationsSinceLastCollect = 0;
+#endif
+
 void* Collector::allocate(size_t s)
 {
@@ -89 +93 @@
     return 0L;
 
+#if APPLE_CHANGES
+  if (++numAllocationsSinceLastCollect >= KJS_MEM_INCREMENT)
+    collect();
+#else
   // Try and deal with memory requirements in a scalable way. Simple scripts
   // should only require small amounts of memory, but for complex scripts we don't
@@ -109 +117 @@
     }
   }
+#endif
 
   void *m = malloc(s);
@@ -251 +260 @@
   }
 
+#if APPLE_CHANGES
+  numAllocationsSinceLastCollect = 0;
+#endif
+
 #if 0
   // This is useful to track down memory leaks