Changeset 226725 in webkit for trunk/Source/JavaScriptCore/bytecode/EvalCodeBlock.h

Timestamp:

Jan 10, 2018, 11:41:12 AM (8 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r226667 and r226673.
​https://bugs.webkit.org/show_bug.cgi?id=181488

This caused a flaky crash. (Requested by mlewis13 on #webkit).

Reverted changesets:

"CodeBlocks should be in IsoSubspaces"
​https://bugs.webkit.org/show_bug.cgi?id=180884
​https://trac.webkit.org/changeset/226667

"REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
​https://bugs.webkit.org/show_bug.cgi?id=180884
​https://trac.webkit.org/changeset/226673

File:

• trunk/Source/JavaScriptCore/bytecode/EvalCodeBlock.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/bytecode/EvalCodeBlock.h

@@ -34 +34 @@
 namespace JSC {
 
-class EvalCodeBlock final : public GlobalCodeBlock {
+class EvalCodeBlock : public GlobalCodeBlock {
 public:
     typedef GlobalCodeBlock Base;
     DECLARE_INFO;
-
-    template<typename>
-    static IsoSubspace* subspaceFor(VM& vm)
-    {
-        return &vm.evalCodeBlockSpace.space;
-    }
 
     static EvalCodeBlock* create(VM* vm, CopyParsedBlockTag, EvalCodeBlock& other)
@@ -65 +59 @@
     static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
     {
-        return Structure::create(vm, globalObject, prototype, TypeInfo(CodeBlockType, StructureFlags), info());
+        return Structure::create(vm, globalObject, prototype, TypeInfo(CellType, StructureFlags), info());
     }