Changeset 227341 in webkit for trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h

Timestamp:

Jan 22, 2018, 10:37:55 AM (8 years ago)

Author:

[email protected]

Message:

DFG abstract interpreter needs to properly model effects of some Math ops
​https://bugs.webkit.org/show_bug.cgi?id=181886

Reviewed by Saam Barati.

JSTests:

New regression test.

• stress/arith-nodes-abstract-interpreter-untypeduse.js: Added.

(test):

Source/JavaScriptCore:

Reviewed the processing of the various ArithXXX and CompareXXX and found that
several nodes don't handle UntypedUse. Added clobberWorld() for those cases.

• dfg/DFGAbstractInterpreter.h:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeDoubleUnaryOpEffects):

File:

• trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h

@@ -189 +189 @@
     void verifyEdge(Node*, Edge);
     void verifyEdges(Node*);
-    void executeDoubleUnaryOpEffects(Node*, double(*equivalentFunction)(double));
+    void executeDoubleUnaryOpEffects(Node*, unsigned clobberLimit, double(*equivalentFunction)(double));
     
     CodeBlock* m_codeBlock;