Changeset 227609 in webkit for trunk/Source/JavaScriptCore/b3/B3Validate.cpp

Timestamp:

Jan 25, 2018, 9:21:09 AM (7 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r227592.
​https://bugs.webkit.org/show_bug.cgi?id=182110

it made ARM64 (Linux and iOS) crash (Requested by pizlo-mbp on
#webkit).

Reverted changeset:

"JSC GC should support TLCs (thread local caches)"
​https://bugs.webkit.org/show_bug.cgi?id=181559
​https://trac.webkit.org/changeset/227592

File:

• trunk/Source/JavaScriptCore/b3/B3Validate.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/b3/B3Validate.cpp

@@ -433 +433 @@
                 if (value->type() == Void)
                     VALIDATE(value->as<PatchpointValue>()->resultConstraint == ValueRep::WarmAny, ("At ", *value));
-                else
+                else {
+                    switch (value->as<PatchpointValue>()->resultConstraint.kind()) {
+                    case ValueRep::WarmAny:
+                    case ValueRep::SomeRegister:
+                    case ValueRep::SomeEarlyRegister:
+                    case ValueRep::Register:
+                    case ValueRep::StackArgument:
+                        break;
+                    default:
+                        VALIDATE(false, ("At ", *value));
+                        break;
+                    }
+                    
                     validateStackmapConstraint(value, ConstrainedValue(value, value->as<PatchpointValue>()->resultConstraint), ConstraintRole::Def);
+                }
                 validateStackmap(value);
                 break;
@@ -559 +572 @@
         switch (value.rep().kind()) {
         case ValueRep::WarmAny:
+        case ValueRep::ColdAny:
+        case ValueRep::LateColdAny:
         case ValueRep::SomeRegister:
         case ValueRep::StackArgument:
-            break;
-        case ValueRep::LateColdAny:
-        case ValueRep::ColdAny:
-            VALIDATE(role == ConstraintRole::Use, ("At ", *context, ": ", value));
-            break;
-        case ValueRep::SomeRegisterWithClobber:
-            VALIDATE(role == ConstraintRole::Use, ("At ", *context, ": ", value));
-            VALIDATE(context->as<PatchpointValue>(), ("At ", *context));
             break;
         case ValueRep::SomeEarlyRegister:
@@ -575 +582 @@
         case ValueRep::Register:
         case ValueRep::LateRegister:
-            if (value.rep().kind() == ValueRep::LateRegister)
-                VALIDATE(role == ConstraintRole::Use, ("At ", *context, ": ", value));
             if (value.rep().reg().isGPR())
                 VALIDATE(isInt(value.value()->type()), ("At ", *context, ": ", value));