Changeset 228402 in webkit for trunk/Source/JavaScriptCore/offlineasm/mips.rb

Timestamp:

Feb 12, 2018, 3:43:30 PM (7 years ago)

Author:

[email protected]

Message:

Miscellaneous refactoring of offlineasm.
​https://bugs.webkit.org/show_bug.cgi?id=182702
<rdar://problem/37467887>

Reviewed by Filip Pizlo.

1. Refactor out the emission of $asm.comment, $asm.codeOrigin, $asm.annotation, and $asm.debugAnnotation into a recordMetaData method. This standardizes how we emit this metadata and makes all backends do it the same way.

2. Add the ability to include custom offlineasm scripts from WebKitAdditions in the future.

• offlineasm/arm.rb:
• offlineasm/arm64.rb:
• offlineasm/ast.rb:
• offlineasm/backends.rb:
• offlineasm/cloop.rb:
• offlineasm/config.rb:
• offlineasm/mips.rb:
• offlineasm/risc.rb:
• offlineasm/x86.rb:

File:

• trunk/Source/JavaScriptCore/offlineasm/mips.rb (modified) (2 diffs)

trunk/Source/JavaScriptCore/offlineasm/mips.rb

@@ -1 @@
-# Copyright (C) 2012 Apple Inc. All rights reserved.
+# Copyright (C) 2012-2018 Apple Inc. All rights reserved.
 # Copyright (C) 2012 MIPS Technologies, Inc. All rights reserved.
 #
@@ -826 +826 @@
 class Instruction
     def lowerMIPS
-        $asm.comment codeOriginString
         case opcode
         when "addi", "addp", "addis"