Changeset 228533 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Feb 15, 2018, 2:34:16 PM (7 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Remove monotonicallyIncreasingTime and currentTime
​https://bugs.webkit.org/show_bug.cgi?id=182793

Reviewed by Saam Barati.

We would like to drop monotonicallyIncreasingTime and currentTime from our tree by
replacing them with MonotonicTime and WallTime, which are well-typed alternatives,
compared to double.
This patch removes monotonicallyIncreasingTime and currentTime in JSC.

• b3/testb3.cpp:

(JSC::B3::testComplex):

• dfg/DFGPhase.h:

(JSC::DFG::runAndLog):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGPlan.h:
• dynbench.cpp:

(JSC::benchmarkImpl):

• heap/BlockDirectory.cpp:

(JSC::BlockDirectory::isPagedOut):

• heap/BlockDirectory.h:
• heap/FullGCActivityCallback.cpp:

(JSC::FullGCActivityCallback::doCollection):

• heap/Heap.cpp:

(JSC::Heap::isPagedOut):
(JSC::Heap::sweepSynchronously):

• heap/Heap.h:
• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::isPagedOut):

• heap/MarkedSpace.h:
• inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::startTiming):
(Inspector::InspectorConsoleAgent::stopTiming):

• inspector/agents/InspectorConsoleAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

• jit/JIT.cpp:

(JSC::JIT::compileWithoutLinking):
(JSC::JIT::compileTimeStats):

• jit/JIT.h:
• jsc.cpp:

(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):
(functionPreciseTime):
(runJSC):

• profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::logEvent):

• profiler/ProfilerEvent.cpp:

(JSC::Profiler::Event::toJS const):

• profiler/ProfilerEvent.h:

(JSC::Profiler::Event::Event):
(JSC::Profiler::Event::time const):

• runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase):

• runtime/CodeCache.h:

(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::prune):

• runtime/DateConstructor.cpp:

(JSC::callDate):

• runtime/TypeProfilerLog.cpp:

(JSC::TypeProfilerLog::processLogEntries):

• testRegExp.cpp:

(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -81 +81 @@
 #include <type_traits>
 #include <wtf/CommaPrinter.h>
-#include <wtf/CurrentTime.h>
 #include <wtf/MainThread.h>
 #include <wtf/NeverDestroyed.h>
 #include <wtf/StringPrintStream.h>
+#include <wtf/WallTime.h>
 #include <wtf/text/StringBuilder.h>
 
@@ -410 +410 @@
 
 private:
-    double m_startTime;
-    double m_stopTime;
+    MonotonicTime m_startTime;
+    MonotonicTime m_stopTime;
 };
 
 void StopWatch::start()
 {
-    m_startTime = monotonicallyIncreasingTime();
+    m_startTime = MonotonicTime::now();
 }
 
 void StopWatch::stop()
 {
-    m_stopTime = monotonicallyIncreasingTime();
+    m_stopTime = MonotonicTime::now();
 }
 
 long StopWatch::getElapsedMS()
 {
-    return static_cast<long>((m_stopTime - m_startTime) * 1000);
+    return (m_stopTime - m_startTime).millisecondsAs<long>();
 }
 
@@ -1378 +1378 @@
 EncodedJSValue JSC_HOST_CALL functionPreciseTime(ExecState*)
 {
-    return JSValue::encode(jsNumber(currentTime()));
+    return JSValue::encode(jsNumber(WallTime::now().secondsSinceEpoch().value()));
 }
 
@@ -2650 +2650 @@
         std::sort(compileTimeKeys.begin(), compileTimeKeys.end());
         for (CString key : compileTimeKeys)
-            printf("%40s: %.3lf ms\n", key.data(), compileTimeStats.get(key));
+            printf("%40s: %.3lf ms\n", key.data(), compileTimeStats.get(key).milliseconds());
     }
 #endif