Changeset 228533 in webkit for trunk/Source/JavaScriptCore/runtime/CodeCache.h

Timestamp:

Feb 15, 2018, 2:34:16 PM (8 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Remove monotonicallyIncreasingTime and currentTime
​https://bugs.webkit.org/show_bug.cgi?id=182793

Reviewed by Saam Barati.

We would like to drop monotonicallyIncreasingTime and currentTime from our tree by
replacing them with MonotonicTime and WallTime, which are well-typed alternatives,
compared to double.
This patch removes monotonicallyIncreasingTime and currentTime in JSC.

• b3/testb3.cpp:

(JSC::B3::testComplex):

• dfg/DFGPhase.h:

(JSC::DFG::runAndLog):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGPlan.h:
• dynbench.cpp:

(JSC::benchmarkImpl):

• heap/BlockDirectory.cpp:

(JSC::BlockDirectory::isPagedOut):

• heap/BlockDirectory.h:
• heap/FullGCActivityCallback.cpp:

(JSC::FullGCActivityCallback::doCollection):

• heap/Heap.cpp:

(JSC::Heap::isPagedOut):
(JSC::Heap::sweepSynchronously):

• heap/Heap.h:
• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::isPagedOut):

• heap/MarkedSpace.h:
• inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::startTiming):
(Inspector::InspectorConsoleAgent::stopTiming):

• inspector/agents/InspectorConsoleAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

• jit/JIT.cpp:

(JSC::JIT::compileWithoutLinking):
(JSC::JIT::compileTimeStats):

• jit/JIT.h:
• jsc.cpp:

(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):
(functionPreciseTime):
(runJSC):

• profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::logEvent):

• profiler/ProfilerEvent.cpp:

(JSC::Profiler::Event::toJS const):

• profiler/ProfilerEvent.h:

(JSC::Profiler::Event::Event):
(JSC::Profiler::Event::time const):

• runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase):

• runtime/CodeCache.h:

(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::prune):

• runtime/DateConstructor.cpp:

(JSC::callDate):

• runtime/TypeProfilerLog.cpp:

(JSC::TypeProfilerLog::processLogEntries):

• testRegExp.cpp:

(StopWatch::start):
(StopWatch::stop):
(StopWatch::getElapsedMS):

File:

• trunk/Source/JavaScriptCore/runtime/CodeCache.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/runtime/CodeCache.h

@@ -84 +84 @@
         : m_size(0)
         , m_sizeAtLastPrune(0)
-        , m_timeAtLastPrune(monotonicallyIncreasingTime())
+        , m_timeAtLastPrune(MonotonicTime::now())
         , m_minCapacity(0)
         , m_capacity(0)
@@ -150 +150 @@
     // This constant factor biases cache capacity toward allowing a minimum
     // working set to enter the cache before it starts evicting.
-    static const double workingSetTime;
+    static const Seconds workingSetTime;
     static const int64_t workingSetMaxBytes = 16000000;
     static const size_t workingSetMaxEntries = 2000;
@@ -172 +172 @@
             return;
 
-        if (monotonicallyIncreasingTime() - m_timeAtLastPrune < workingSetTime
+        if (MonotonicTime::now() - m_timeAtLastPrune < workingSetTime
             && m_size - m_sizeAtLastPrune < workingSetMaxBytes
             && canPruneQuickly())
@@ -183 +183 @@
     int64_t m_size;
     int64_t m_sizeAtLastPrune;
-    double m_timeAtLastPrune;
+    MonotonicTime m_timeAtLastPrune;
     int64_t m_minCapacity;
     int64_t m_capacity;