Changeset 229852 in webkit for trunk/Source/JavaScriptCore/bytecode/BytecodeDumper.cpp

Timestamp:

Mar 22, 2018, 8:40:57 AM (7 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Drop op_put_by_index
​https://bugs.webkit.org/show_bug.cgi?id=183899

Reviewed by Mark Lam.

This patch drops op_put_by_index.

1. This functionality can be just covered by direct put_by_val.
2. put_by_index is not well optimized. It is just calling a C

function. And it does not have DFG handling.

• bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

• bytecode/BytecodeList.json:
• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPutByIndex): Deleted.

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

• jit/JIT.h:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_index): Deleted.

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_index): Deleted.

• llint/LLIntSlowPaths.cpp:
• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:

File:

• trunk/Source/JavaScriptCore/bytecode/BytecodeDumper.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bytecode/BytecodeDumper.cpp

@@ -1188 +1188 @@
         break;
     }
-    case op_put_by_index: {
-        int r0 = (++it)->u.operand;
-        unsigned n0 = (++it)->u.operand;
-        int r1 = (++it)->u.operand;
-        printLocationAndOp(out, location, it, "put_by_index");
-        out.printf("%s, %u, %s", registerName(r0).data(), n0, registerName(r1).data());
-        break;
-    }
     case op_jmp: {
         int offset = (++it)->u.operand;