Changeset 229854 in webkit for trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp

Timestamp:

Mar 22, 2018, 8:58:59 AM (7 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] List up all candidates in DFGCapabilities and FTLCapabilities
​https://bugs.webkit.org/show_bug.cgi?id=183897

Reviewed by Mark Lam.

We should not use default: clause here since it accidentally catches
the opcode and DFG nodes which should be optimized. For example,
op_super_sampler_begin and op_super_sampler_end are not listed while
they have DFG and FTL backend.

This patch lists up all candiates in DFGCapabilities and FTLCapabilities.
And we also clean up unnecessary checks in FTLCapabilities. Since we
already handles all the possible array types for these nodes (which can
be checked in DFG's code), we do not need to check array types.

We also fix FTLLowerDFGToB3' PutByVal code to use modeForPut.

• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):

File:

• trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGCapabilities.cpp

@@ -266 +266 @@
     case op_new_regexp:
     case op_unreachable:
+    case op_super_sampler_begin:
+    case op_super_sampler_end:
         return CanCompileAndInline;
 
@@ -272 +274 @@
         return CanCompile;
 
-    default:
+    case op_yield:
+    case llint_program_prologue:
+    case llint_eval_prologue:
+    case llint_module_program_prologue:
+    case llint_function_for_call_prologue:
+    case llint_function_for_construct_prologue:
+    case llint_function_for_call_arity_check:
+    case llint_function_for_construct_arity_check:
+    case llint_generic_return_point:
+    case llint_throw_from_slow_path_trampoline:
+    case llint_throw_during_call_trampoline:
+    case llint_native_call_trampoline:
+    case llint_native_construct_trampoline:
+    case llint_internal_function_call_trampoline:
+    case llint_internal_function_construct_trampoline:
+    case handleUncaughtException:
         return CannotCompile;
     }
+    return CannotCompile;
 }