Changeset 230741 in webkit for trunk/Source/JavaScriptCore/runtime/JSModuleLoader.cpp

Timestamp:

Apr 17, 2018, 5:05:07 PM (7 years ago)

Author:

Matt Lewis

Message:

Unreviewed, rolling out r230697, r230720, and r230724.
​https://bugs.webkit.org/show_bug.cgi?id=184717

These caused multiple failures on the Test262 testers.
(Requested by mlewis13 on #webkit).

Reverted changesets:

"[WebAssembly][Modules] Prototype wasm import"
​https://bugs.webkit.org/show_bug.cgi?id=184600
​https://trac.webkit.org/changeset/230697

"[WebAssembly][Modules] Implement function import from wasm
modules"
​https://bugs.webkit.org/show_bug.cgi?id=184689
​https://trac.webkit.org/changeset/230720

"[JSC] Rename runWebAssembly to runWebAssemblySuite"
​https://bugs.webkit.org/show_bug.cgi?id=184703
​https://trac.webkit.org/changeset/230724

Patch by Commit Queue <​[email protected]> on 2018-04-17

File:

• trunk/Source/JavaScriptCore/runtime/JSModuleLoader.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSModuleLoader.cpp

@@ -276 +276 @@
         return globalObject->globalObjectMethodTable()->moduleLoaderEvaluate(globalObject, exec, this, key, moduleRecordValue, scriptFetcher);
 
-    if (auto* moduleRecord = jsDynamicCast<AbstractModuleRecord*>(exec->vm(), moduleRecordValue))
-        return moduleRecord->evaluate(exec);
-    return jsUndefined();
+    JSModuleRecord* moduleRecord = jsDynamicCast<JSModuleRecord*>(exec->vm(), moduleRecordValue);
+    if (!moduleRecord)
+        return jsUndefined();
+    return moduleRecord->evaluate(exec);
 }