Changeset 230826 in webkit for trunk/Source/JavaScriptCore/tools/CodeProfiling.cpp

Timestamp:

Apr 19, 2018, 4:30:47 PM (7 years ago)

Author:

[email protected]

Message:

Apply pointer profiling to Signal pointers.
​https://bugs.webkit.org/show_bug.cgi?id=184790
<rdar://problem/39301369>

Reviewed by Michael Saboff.

1. Change stackPointer, framePointer, and instructionPointer accessors to be a pair of getter/setter functions.
2. Add support for USE(PLATFORM_REGISTERS_WITH_PROFILE) to allow use of a a pointer profiling variants of these accessors.
3. Also add a linkRegister accessor only for ARM64 on OS(DARWIN).

• JavaScriptCorePrefix.h:
• runtime/MachineContext.h:

(JSC::MachineContext::stackPointerImpl):
(JSC::MachineContext::stackPointer):
(JSC::MachineContext::setStackPointer):
(JSC::MachineContext::framePointerImpl):
(JSC::MachineContext::framePointer):
(JSC::MachineContext::setFramePointer):
(JSC::MachineContext::instructionPointerImpl):
(JSC::MachineContext::instructionPointer):
(JSC::MachineContext::setInstructionPointer):
(JSC::MachineContext::linkRegisterImpl):
(JSC::MachineContext::linkRegister):
(JSC::MachineContext::setLinkRegister):

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::takeSample):

• runtime/VMTraps.cpp:

(JSC::SignalContext::SignalContext):
(JSC::VMTraps::tryInstallTrapBreakpoints):

• tools/CodeProfiling.cpp:

(JSC::profilingTimer):

• tools/SigillCrashAnalyzer.cpp:

(JSC::SignalContext::dump):
(JSC::installCrashHandler):
(JSC::SigillCrashAnalyzer::analyze):

• wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):

File:

• trunk/Source/JavaScriptCore/tools/CodeProfiling.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/tools/CodeProfiling.cpp

@@ -1 +1 @@
 /*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2018 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -73 +73 @@
     PlatformRegisters& platformRegisters = WTF::registersFromUContext(static_cast<ucontext_t*>(uap));
     CodeProfiling::sample(
-        MachineContext::instructionPointer(platformRegisters),
+        MachineContext::instructionPointer(platformRegisters).untaggedExecutableAddress(),
         reinterpret_cast<void**>(MachineContext::framePointer(platformRegisters)));
 }