Changeset 232132 in webkit for trunk/Source/JavaScriptCore/runtime/JSString.cpp

Timestamp:

May 23, 2018, 3:34:18 PM (7 years ago)

Author:

[email protected]

Message:

Speed up JetStream/base64
​https://bugs.webkit.org/show_bug.cgi?id=185914

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Make allocation fast paths ALWAYS_INLINE.

This is a 1% speed-up on SunSpider, mostly because of base64. It also speeds up pdfjs by
~6%.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/AllocatorInlines.h:

(JSC::Allocator::allocate const):

• heap/CompleteSubspace.cpp:

(JSC::CompleteSubspace::allocateNonVirtual): Deleted.

• heap/CompleteSubspace.h:
• heap/CompleteSubspaceInlines.h: Added.

(JSC::CompleteSubspace::allocateNonVirtual):

• heap/FreeListInlines.h:

(JSC::FreeList::allocate):

• heap/IsoSubspace.cpp:

(JSC::IsoSubspace::allocateNonVirtual): Deleted.

• heap/IsoSubspace.h:

(JSC::IsoSubspace::allocatorForNonVirtual):

• heap/IsoSubspaceInlines.h: Added.

(JSC::IsoSubspace::allocateNonVirtual):

• runtime/JSCellInlines.h:
• runtime/VM.h:

Source/WTF:

Make Vector<>::append ALWAYS_INLINE.

• wtf/Vector.h:

(WTF::Vector::append):
(WTF::minCapacity>::expandCapacity):
(WTF::minCapacity>::append):
(WTF::minCapacity>::tryAppend):

File:

• trunk/Source/JavaScriptCore/runtime/JSString.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSString.cpp

@@ -296 +296 @@
 // Vector before performing any concatenation, but by working backwards we likely
 // only fill the queue with the number of substrings at any given level in a
-// rope-of-ropes.)    
+// rope-of-ropes.)
 void JSRopeString::resolveRopeSlowCase8(LChar* buffer) const
 {