Changeset 233085 in webkit for trunk/Source/JavaScriptCore/runtime/EvalExecutable.cpp

Timestamp:

Jun 22, 2018, 11:26:36 AM (7 years ago)

Author:

[email protected]

Message:

We should call visitChildren on Base not the exact typename
​https://bugs.webkit.org/show_bug.cgi?id=186928

Reviewed by Mark Lam.

A lot of places were not properly calling visitChildren on their
superclass. For most of them it didn't matter because they had
immortal structures. If code changed in the future this might
break things however.

Also, block off more of the MethodTable for GetterSetter objects.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitChildren):

• bytecode/ExecutableToCodeBlockEdge.cpp:

(JSC::ExecutableToCodeBlockEdge::visitChildren):

• debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::visitChildren):

• runtime/EvalExecutable.cpp:

(JSC::EvalExecutable::visitChildren):

• runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::visitChildren):

• runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::visitChildren):

• runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::visitChildren):

• runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

• runtime/GetterSetter.h:
• runtime/InferredType.cpp:

(JSC::InferredType::visitChildren):

• runtime/InferredTypeTable.cpp:

(JSC::InferredTypeTable::visitChildren):

• runtime/InferredValue.cpp:

(JSC::InferredValue::visitChildren):

• runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::visitChildren):

• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

• runtime/ModuleProgramExecutable.cpp:

(JSC::ModuleProgramExecutable::visitChildren):

• runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::visitChildren):

• runtime/ScopedArguments.cpp:

(JSC::ScopedArguments::visitChildren):

• runtime/ScopedArguments.h:
• runtime/Structure.cpp:

(JSC::Structure::visitChildren):

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):

• runtime/SymbolTable.cpp:

(JSC::SymbolTable::visitChildren):

File:

• trunk/Source/JavaScriptCore/runtime/EvalExecutable.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/EvalExecutable.cpp

@@ -49 +49 @@
     EvalExecutable* thisObject = jsCast<EvalExecutable*>(cell);
     ASSERT_GC_OBJECT_INHERITS(thisObject, info());
-    ScriptExecutable::visitChildren(thisObject, visitor);
+    Base::visitChildren(thisObject, visitor);
     visitor.append(thisObject->m_unlinkedEvalCodeBlock);
     visitor.append(thisObject->m_evalCodeBlock);