Changeset 233245 in webkit for trunk/Source/JavaScriptCore/runtime/InternalFunction.cpp

Timestamp:

Jun 26, 2018, 10:01:29 PM (7 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Pass VM& to functions more
​https://bugs.webkit.org/show_bug.cgi?id=186241

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch threads VM& to functions requiring VM& more.

• API/JSObjectRef.cpp:

(JSObjectIsConstructor):

• bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:

(JSC::AdaptiveInferredPropertyValueWatchpointBase::install):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::fire):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint::fireInternal):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint::fireInternal):

• bytecode/AdaptiveInferredPropertyValueWatchpointBase.h:
• bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

• bytecode/CodeBlockJettisoningWatchpoint.h:
• bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:

(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::install):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):

• bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
• bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::fireInternal):

• bytecode/StructureStubClearingWatchpoint.h:
• bytecode/Watchpoint.cpp:

(JSC::Watchpoint::fire):
(JSC::WatchpointSet::fireAllWatchpoints):

• bytecode/Watchpoint.h:
• dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::handleFire):

• dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h:
• dfg/DFGAdaptiveStructureWatchpoint.cpp:

(JSC::DFG::AdaptiveStructureWatchpoint::install):
(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):

• dfg/DFGAdaptiveStructureWatchpoint.h:
• dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setupGetByIdPrototypeCache):

• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::tryInitializeSpeciesWatchpoint):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):

• runtime/ECMAScriptSpecInternalFunctions.cpp:

(JSC::esSpecIsConstructor):

• runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::AllocationProfileClearingWatchpoint::fireInternal):

• runtime/FunctionRareData.h:
• runtime/InferredStructureWatchpoint.cpp:

(JSC::InferredStructureWatchpoint::fireInternal):

• runtime/InferredStructureWatchpoint.h:
• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createSubclassStructureSlow):

• runtime/InternalFunction.h:

(JSC::InternalFunction::createSubclassStructure):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::isConstructor const):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isConstructor):
(JSC::JSCell::methodTable const):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/ObjectPropertyChangeAdaptiveWatchpoint.h:

(JSC::ObjectPropertyChangeAdaptiveWatchpoint::ObjectPropertyChangeAdaptiveWatchpoint):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::finishCreation):

• runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::setObjectToStringValue):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire):

Source/WebCore:

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

File:

• trunk/Source/JavaScriptCore/runtime/InternalFunction.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/InternalFunction.cpp

@@ -116 +116 @@
     VM& vm = exec->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);
-    ASSERT(!newTarget || newTarget.isConstructor());
+    ASSERT(!newTarget || newTarget.isConstructor(vm));
     ASSERT(newTarget && newTarget != exec->jsCallee());