Changeset 233721 in webkit for trunk/Source/JavaScriptCore/runtime/JSDataView.cpp

Timestamp:

Jul 10, 2018, 10:00:13 PM (7 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Remove getTypedArrayImpl
​https://bugs.webkit.org/show_bug.cgi?id=187338

Reviewed by Mark Lam.

getTypedArrayImpl is overridden only by typed arrays and DataView. Since the number of these classes
are limited, we do not need to add this function to MethodTable: dispatching it in JSArrayBufferView is fine.
This patch removes getTypedArrayImpl from MethodTable, and moves it to JSArrayBufferView.

• runtime/ClassInfo.h:
• runtime/GenericTypedArrayView.h:

(JSC::GenericTypedArrayView::data const): Deleted.
(JSC::GenericTypedArrayView::set): Deleted.
(JSC::GenericTypedArrayView::setRange): Deleted.
(JSC::GenericTypedArrayView::zeroRange): Deleted.
(JSC::GenericTypedArrayView::zeroFill): Deleted.
(JSC::GenericTypedArrayView::length const): Deleted.
(JSC::GenericTypedArrayView::item const): Deleted.
(JSC::GenericTypedArrayView::set const): Deleted.
(JSC::GenericTypedArrayView::setNative const): Deleted.
(JSC::GenericTypedArrayView::getRange): Deleted.
(JSC::GenericTypedArrayView::checkInboundData const): Deleted.
(JSC::GenericTypedArrayView::internalByteLength const): Deleted.

• runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::possiblySharedImpl):

• runtime/JSArrayBufferView.h:
• runtime/JSArrayBufferViewInlines.h:

(JSC::JSArrayBufferView::possiblySharedImpl): Deleted.

• runtime/JSCell.cpp:

(JSC::JSCell::getTypedArrayImpl): Deleted.

• runtime/JSCell.h:
• runtime/JSDataView.cpp:

(JSC::JSDataView::getTypedArrayImpl): Deleted.

• runtime/JSDataView.h:
• runtime/JSGenericTypedArrayView.h:
• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getTypedArrayImpl): Deleted.

File:

• trunk/Source/JavaScriptCore/runtime/JSDataView.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSDataView.cpp

@@ -181 +181 @@
 }
 
-RefPtr<ArrayBufferView> JSDataView::getTypedArrayImpl(JSArrayBufferView* object)
-{
-    JSDataView* thisObject = jsCast<JSDataView*>(object);
-    return thisObject->possiblySharedTypedImpl();
-}
-
 Structure* JSDataView::createStructure(
     VM& vm, JSGlobalObject* globalObject, JSValue prototype)