Changeset 236305 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Sep 20, 2018, 9:36:08 PM (7 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r236293.

Internal build still broken.

Reverted changeset:

"Add functions to measure memory footprint to JSC"
​https://bugs.webkit.org/show_bug.cgi?id=189768
​https://trac.webkit.org/changeset/236293

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -128 +128 @@
 #endif
 
-#if __has_include(<WebKitAdditions/MemoryFootprint.h>)
-#include <WebKitAdditions/MemoryFootprint.h>
-#else
-struct MemoryFootprint {
-    uint64_t current;
-    uint64_t peak;
-    
-    static MemoryFootprint now()
-    {
-        return { 0L, 0L };
-    }
-    
-    static void resetPeak()
-    {
-    }
-};
-#endif
-
 #if !defined(PATH_MAX)
 #define PATH_MAX 4096
@@ -286 +268 @@
 static EncodedJSValue JSC_HOST_CALL functionForceGCSlowPaths(ExecState*);
 static EncodedJSValue JSC_HOST_CALL functionHeapSize(ExecState*);
-static EncodedJSValue JSC_HOST_CALL functionCreateMemoryFootprint(ExecState*);
-static EncodedJSValue JSC_HOST_CALL functionResetMemoryPeak(ExecState*);
 static EncodedJSValue JSC_HOST_CALL functionAddressOf(ExecState*);
 static EncodedJSValue JSC_HOST_CALL functionVersion(ExecState*);
@@ -505 +485 @@
         addFunction(vm, "forceGCSlowPaths", functionForceGCSlowPaths, 0);
         addFunction(vm, "gcHeapSize", functionHeapSize, 0);
-        addFunction(vm, "MemoryFootprint", functionCreateMemoryFootprint, 0);
-        addFunction(vm, "resetMemoryPeak", functionResetMemoryPeak, 0);
         addFunction(vm, "addressOf", functionAddressOf, 1);
         addFunction(vm, "version", functionVersion, 1);
@@ -1202 +1180 @@
 }
 
-class JSCMemoryFootprint : public JSDestructibleObject {
-    using Base = JSDestructibleObject;
-public:
-    JSCMemoryFootprint(VM& vm, Structure* structure)
-        : Base(vm, structure)
-    { }
-
-    static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
-    {
-        return Structure::create(vm, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), info());
-    }
-
-    static JSCMemoryFootprint* create(VM& vm, JSGlobalObject* globalObject)
-    {
-        Structure* structure = createStructure(vm, globalObject, jsNull());
-        JSCMemoryFootprint* footprint = new (NotNull, allocateCell<JSCMemoryFootprint>(vm.heap, sizeof(JSCMemoryFootprint))) JSCMemoryFootprint(vm, structure);
-        footprint->finishCreation(vm);
-        return footprint;
-    }
-
-    void finishCreation(VM& vm)
-    {
-        Base::finishCreation(vm);
-
-        auto addProperty = [&] (VM& vm, const char* name, JSValue value) {
-            JSCMemoryFootprint::addProperty(vm, name, value);
-        };
-
-        MemoryFootprint footprint = MemoryFootprint::now();
-
-        // Report sizes in KBytes so that values up to GB are still integers.
-        addProperty(vm, "current", jsNumber(footprint.current / 1024));
-        addProperty(vm, "peak", jsNumber(footprint.peak / 1024));
-    }
-
-    DECLARE_INFO;
-
-private:
-    void addProperty(VM& vm, const char* name, JSValue value)
-    {
-        Identifier identifier = Identifier::fromString(&vm, name);
-        putDirect(vm, identifier, value);
-    }
-};
-
-const ClassInfo JSCMemoryFootprint::s_info = { "MemoryFootprint", &Base::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(JSCMemoryFootprint) };
-
-EncodedJSValue JSC_HOST_CALL functionCreateMemoryFootprint(ExecState* exec)
-{
-    VM& vm = exec->vm();
-    JSLockHolder lock(vm);
-    return JSValue::encode(JSCMemoryFootprint::create(vm, exec->lexicalGlobalObject()));
-}
-
-EncodedJSValue JSC_HOST_CALL functionResetMemoryPeak(ExecState*)
-{
-    MemoryFootprint::resetPeak();
-    return JSValue::encode(jsUndefined());
-}
-
 // This function is not generally very helpful in 64-bit code as the tag and payload
 // share a register. But in 32-bit JITed code the tag may not be checked if an