Changeset 236450 in webkit for trunk/Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp

Timestamp:

Sep 24, 2018, 8:05:13 PM (7 years ago)

Author:

Fujii Hironori

Message:

Rename WTF_COMPILER_GCC_OR_CLANG to WTF_COMPILER_GCC_COMPATIBLE
​https://bugs.webkit.org/show_bug.cgi?id=189733

Reviewed by Michael Catanzaro.

Source/bmalloc:

• bmalloc/BCompiler.h:

Source/JavaScriptCore:

• assembler/ARM64Assembler.h:
• assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

• assembler/MacroAssemblerARM.cpp:

(JSC::isVFPPresent):

• assembler/MacroAssemblerARM64.cpp:
• assembler/MacroAssemblerARMv7.cpp:
• assembler/MacroAssemblerMIPS.cpp:
• assembler/MacroAssemblerX86Common.cpp:
• heap/HeapCell.cpp:
• heap/HeapCell.h:
• jit/HostCallReturnValue.h:
• jit/JIT.h:
• jit/JITOperations.cpp:
• jit/ThunkGenerators.cpp:
• runtime/ArrayConventions.cpp:

(JSC::clearArrayMemset):

• runtime/JSBigInt.cpp:

(JSC::JSBigInt::digitDiv):

Source/WebCore:

No new tests (No behavior change).

• platform/graphics/cpu/arm/filters/FELightingNEON.cpp:
• platform/graphics/cpu/arm/filters/FELightingNEON.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApply):

• platform/graphics/filters/FELighting.h:

Source/WTF:

Clang for Windows build enables WTF_COMPILER_CLANG and
WTF_COMPILER_MSVC, but disables WTF_COMPILER_GCC_OR_CLANG. It is
strange WTF_COMPILER_GCC_OR_CLANG is not enabled even though
WTF_COMPILER_CLANG is enabled. However, Clang for Windows imitates
MSVC, and codes for COMPILER(GCC_OR_CLANG) are for non MSVC. At
least at the moment, it is not feasible to define
WTF_COMPILER_GCC_OR_CLANG for Clang for Windows.

To solve the issue, this change renames WTF_COMPILER_GCC_OR_CLANG
to WTF_COMPILER_GCC_COMPATIBLE.

As an exception, I'd like to use IGNORE_WARNINGS_* macros even in
Clang for Windows builds.

• wtf/Assertions.cpp: Replaced COMPILER(GCC_OR_CLANG) with COMPILER(GCC_COMPATIBLE).
• wtf/Assertions.h: Ditto.
• wtf/Atomics.h: Ditto.
• wtf/CheckedArithmetic.h: Ditto.
• wtf/FastMalloc.h: Ditto.
• wtf/MathExtras.h: Ditto.
• wtf/Platform.h: Ditto.
• wtf/StdLibExtras.h: Ditto.
• wtf/Vector.h: Ditto.
• wtf/text/ASCIIFastPath.h: Ditto.

wtf/Compiler.h: Ditto. Replaced "COMPILER(GCC_OR_CLANG)" with "COMPILER(GCC)

COMPILER(CLANG)" of IGNORE_WARNINGS_* macros.

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp

@@ -172 +172 @@
 
 #if CPU(X86)
-#if COMPILER(GCC_OR_CLANG)
+#if COMPILER(GCC_COMPATIBLE)
 asm (
     ".globl " SYMBOL_STRING(ctiMasmProbeTrampoline) "\n"
@@ -512 +512 @@
 
 #if CPU(X86_64)
-#if COMPILER(GCC_OR_CLANG)
+#if COMPILER(GCC_COMPATIBLE)
 asm (
     ".globl " SYMBOL_STRING(ctiMasmProbeTrampoline) "\n"
@@ -706 +706 @@
     "ret" "\n"
 );
-#endif // COMPILER(GCC_OR_CLANG)
+#endif // COMPILER(GCC_COMPATIBLE)
 #endif // CPU(X86_64)