Changeset 236750 in webkit for trunk/Source/WebCore/css/CSSValue.cpp

Timestamp:

Oct 2, 2018, 10:36:05 AM (7 years ago)

Author:

[email protected]

Message:

Remove CSS Animation Triggers
​https://bugs.webkit.org/show_bug.cgi?id=190175
<rdar://problem/44925626>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Remove the never-properly specified CSS Animation Triggers.

• Configurations/FeatureDefines.xcconfig:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSAnimationTriggerScrollValue.cpp: Removed.
• css/CSSAnimationTriggerScrollValue.h: Removed.
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
(WebCore::createAnimationTriggerValue): Deleted.
(WebCore::animationTriggerValue): Deleted.

• css/CSSProperties.json:
• css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTrigger): Deleted.

• css/CSSToStyleMap.h:
• css/CSSValue.cpp:

(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):

• css/CSSValue.h:

(WebCore::CSSValue::isAnimationTriggerScrollValue const): Deleted.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAnimationValue):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeWebkitAnimationTrigger): Deleted.

• page/FrameView.cpp:

(WebCore::FrameView::sendScrollEvent):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setAnimationTriggersEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::animationTriggersEnabled const): Deleted.

• page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::timeToNextService):
(WebCore::AnimationBase::getElapsedTime const):

• page/animation/CSSAnimationController.cpp:

(WebCore::CSSAnimationControllerPrivate::animationWillBeRemoved):
(WebCore::CSSAnimationControllerPrivate::addToAnimationsDependentOnScroll): Deleted.
(WebCore::CSSAnimationControllerPrivate::removeFromAnimationsDependentOnScroll): Deleted.
(WebCore::CSSAnimationControllerPrivate::scrollWasUpdated): Deleted.
(WebCore::CSSAnimationController::wantsScrollUpdates const): Deleted.
(WebCore::CSSAnimationController::scrollWasUpdated): Deleted.

• page/animation/CSSAnimationController.h:
• page/animation/CSSAnimationControllerPrivate.h:

(WebCore::CSSAnimationControllerPrivate::wantsScrollUpdates const): Deleted.
(WebCore::CSSAnimationControllerPrivate::scrollPosition const): Deleted.

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateKeyframeAnimations):

• page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::hasScrollTriggeredAnimation const): Deleted.

• platform/animation/Animation.cpp:

(WebCore::Animation::Animation):
(WebCore::Animation::operator=):
(WebCore::Animation::animationsMatch const):

• platform/animation/Animation.h:

(WebCore::Animation::isTimingFunctionSet const):
(WebCore::Animation::isEmpty const):
(WebCore::Animation::clearTimingFunction):
(WebCore::Animation::clearAll):
(WebCore::Animation::animationMode const):
(WebCore::Animation::setAnimationMode):
(WebCore::Animation::initialTimingFunction):
(WebCore::Animation::isTriggerSet const): Deleted.
(WebCore::Animation::clearTrigger): Deleted.
(WebCore::Animation::trigger const): Deleted.
(WebCore::Animation::setTrigger): Deleted.
(WebCore::Animation::initialTrigger): Deleted.

• platform/animation/AnimationTrigger.h: Removed.
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::animationCanBeAccelerated const):

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Remove a bunch of tests that no longer have an implementation.

• TestExpectations:
• animations/trigger-computed-style-expected.txt: Removed.
• animations/trigger-computed-style.html: Removed.
• animations/trigger-container-scroll-boundaries-expected.txt: Removed.
• animations/trigger-container-scroll-boundaries.html: Removed.
• animations/trigger-container-scroll-empty-expected.txt: Removed.
• animations/trigger-container-scroll-empty.html: Removed.
• animations/trigger-container-scroll-simple-expected.txt: Removed.
• animations/trigger-container-scroll-simple.html: Removed.
• animations/trigger-parsing-expected.txt: Removed.
• animations/trigger-parsing.html: Removed.
• fast/css/compare-animation-trigger-expected.txt: Removed.
• fast/css/compare-animation-trigger.html: Removed.
• legacy-animation-engine/animations/trigger-computed-style-expected.txt: Removed.
• legacy-animation-engine/animations/trigger-computed-style.html: Removed.
• legacy-animation-engine/animations/trigger-container-scroll-boundaries-expected.txt: Removed.
• legacy-animation-engine/animations/trigger-container-scroll-boundaries.html: Removed.
• legacy-animation-engine/animations/trigger-container-scroll-empty-expected.txt: Removed.
• legacy-animation-engine/animations/trigger-container-scroll-empty.html: Removed.
• legacy-animation-engine/animations/trigger-container-scroll-simple-expected.txt: Removed.
• legacy-animation-engine/animations/trigger-container-scroll-simple.html: Removed.
• legacy-animation-engine/animations/trigger-parsing-expected.txt: Removed.
• legacy-animation-engine/animations/trigger-parsing.html: Removed.
• legacy-animation-engine/fast/css/compare-animation-trigger-expected.txt: Removed.
• legacy-animation-engine/fast/css/compare-animation-trigger.html: Removed.
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/wincairo/TestExpectations:

File:

• trunk/Source/WebCore/css/CSSValue.cpp (modified) (4 diffs)

trunk/Source/WebCore/css/CSSValue.cpp

@@ -29 +29 @@
 #include "CSSValue.h"
 
-#include "CSSAnimationTriggerScrollValue.h"
 #include "CSSAspectRatioValue.h"
 #include "CSSBorderImageSliceValue.h"
@@ -201 +200 @@
         case ImageSetClass:
             return compareCSSValues<CSSImageSetValue>(*this, other);
-#if ENABLE(CSS_ANIMATIONS_LEVEL_2)
-        case AnimationTriggerScrollClass:
-            return compareCSSValues<CSSAnimationTriggerScrollValue>(*this, other);
-#endif
         case CSSContentDistributionClass:
             return compareCSSValues<CSSContentDistributionValue>(*this, other);
@@ -303 +298 @@
     case ImageSetClass:
         return downcast<CSSImageSetValue>(*this).customCSSText();
-#if ENABLE(CSS_ANIMATIONS_LEVEL_2)
-    case AnimationTriggerScrollClass:
-        return downcast<CSSAnimationTriggerScrollValue>(*this).customCSSText();
-#endif
     case CSSContentDistributionClass:
         return downcast<CSSContentDistributionValue>(*this).customCSSText();
@@ -437 +428 @@
         delete downcast<CSSFilterImageValue>(this);
         return;
-#if ENABLE(CSS_ANIMATIONS_LEVEL_2)
-    case AnimationTriggerScrollClass:
-        delete downcast<CSSAnimationTriggerScrollValue>(this);
-        return;
-#endif
     case CSSContentDistributionClass:
         delete downcast<CSSContentDistributionValue>(this);