Changeset 236805 in webkit for trunk/Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp

Timestamp:

Oct 3, 2018, 11:38:11 AM (7 years ago)

Author:

[email protected]

Message:

bmalloc, WTF and JavaScriptCore parts of [Xcode] Update some build settings as recommended by Xcode 10
​https://bugs.webkit.org/show_bug.cgi?id=190250

Reviewed by Alex Christensen.

Source/bmalloc:

• Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.

• bmalloc.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.

Source/JavaScriptCore:

• API/tests/Regress141275.mm:

(-[JSTEvaluator _sourcePerform]): Addressed newly-enabled CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF

by making the self-retaining explicit.

• API/tests/testapi.cpp:

(testCAPIViaCpp): Addressed newly-enabled CLANG_WARN_UNREACHABLE_CODE by breaking out of the

loop instead of returning from the lambda.

• Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.

• JavaScriptCore.xcodeproj/project.pbxproj: Removed a duplicate reference to UnlinkedFunctionExecutable.h, and let Xcode update the project file.

• assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printAllRegisters): Addressed newly-enabled CLANG_WARN_COMMA by replacing

some commas with semicolons.

Source/WTF:

• Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.

• WTF.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.

• wtf/MathExtras.h:

(WTF::fastLog2): Addressed newly-enabled CLANG_WARN_COMMA by splitting some comma-separated

expressions into individual statements.

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp

@@ -54 +54 @@
 #define INDENT indent()
 
-    INDENT, out.print("cpu: {\n");
+    INDENT; out.print("cpu: {\n");
 
 #if USE(JSVALUE32_64)
@@ -64 +64 @@
     for (auto id = MacroAssembler::firstRegister(); id <= MacroAssembler::lastRegister(); id = nextID(id)) {
         intptr_t value = static_cast<intptr_t>(cpu.gpr(id));
-        INDENT, out.printf("    %6s: " INTPTR_HEX_VALUE_FORMAT "  %" PRIdPTR "\n", cpu.gprName(id), value, value);
+        INDENT; out.printf("    %6s: " INTPTR_HEX_VALUE_FORMAT "  %" PRIdPTR "\n", cpu.gprName(id), value, value);
     }
     for (auto id = MacroAssembler::firstSPRegister(); id <= MacroAssembler::lastSPRegister(); id = nextID(id)) {
         intptr_t value = static_cast<intptr_t>(cpu.spr(id));
-        INDENT, out.printf("    %6s: " INTPTR_HEX_VALUE_FORMAT "  %" PRIdPTR "\n", cpu.sprName(id), value, value);
+        INDENT; out.printf("    %6s: " INTPTR_HEX_VALUE_FORMAT "  %" PRIdPTR "\n", cpu.sprName(id), value, value);
     }
     #undef INTPTR_HEX_VALUE_FORMAT
@@ -75 +75 @@
         uint64_t u = bitwise_cast<uint64_t>(cpu.fpr(id));
         double d = cpu.fpr(id);
-        INDENT, out.printf("    %6s: 0x%016" PRIx64 "  %.13g\n", cpu.fprName(id), u, d);
+        INDENT; out.printf("    %6s: 0x%016" PRIx64 "  %.13g\n", cpu.fprName(id), u, d);
     }
 
-    INDENT, out.print("}\n");
+    INDENT; out.print("}\n");
 #undef INDENT