Changeset 236998 in webkit for trunk/Source/WebCore/css/CSSValue.cpp

Timestamp:

Oct 9, 2018, 11:55:24 PM (7 years ago)

Author:

[email protected]

Message:

Remove the frames() timing function
​https://bugs.webkit.org/show_bug.cgi?id=190034
<rdar://problem/44827544>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

• web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt:
• web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt:
• web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance-expected.txt:
• web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt:
• web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt:

Source/WebCore:

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::createTimingFunctionValue):

• css/CSSTimingFunctionValue.cpp:

(WebCore::CSSFramesTimingFunctionValue::customCSSText const): Deleted.
(WebCore::CSSFramesTimingFunctionValue::equals const): Deleted.

• css/CSSTimingFunctionValue.h:
• css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

• css/CSSValue.cpp:

(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):

• css/CSSValue.h:

(WebCore::CSSValue::isStepsTimingFunctionValue const):
(WebCore::CSSValue::isFramesTimingFunctionValue const): Deleted.

• css/CSSValueKeywords.in:
• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAnimationTimingFunction):
(WebCore::consumeFrames): Deleted.

• platform/animation/TimingFunction.cpp:

(WebCore::operator<<):
(WebCore::TimingFunction::transformTime const):
(WebCore::TimingFunction::createFromCSSValue):

• platform/animation/TimingFunction.h:

(WebCore::TimingFunction::isStepsTimingFunction const):
(WebCore::TimingFunction::isFramesTimingFunction const): Deleted.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::animationCanBeAccelerated const):
(WebCore::animationHasFramesTimingFunction): Deleted.

Source/WebKit:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<FramesTimingFunction>::encode): Deleted.
(IPC::ArgumentCoder<FramesTimingFunction>::decode): Deleted.

• Shared/WebCoreArgumentCoders.h:
• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::PlatformCAAnimationRemote::Properties::encode const):
(WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

• legacy-animation-engine/transitions/frames-timing-function-expected.txt:
• legacy-animation-engine/transitions/transitions-parsing-expected.txt:
• transitions/frames-timing-function-expected.txt:
• transitions/transitions-parsing-expected.txt:

File:

• trunk/Source/WebCore/css/CSSValue.cpp (modified) (3 diffs)

trunk/Source/WebCore/css/CSSValue.cpp

@@ -198 +198 @@
         case StepsTimingFunctionClass:
             return compareCSSValues<CSSStepsTimingFunctionValue>(*this, other);
-        case FramesTimingFunctionClass:
-            return compareCSSValues<CSSFramesTimingFunctionValue>(*this, other);
         case SpringTimingFunctionClass:
             return compareCSSValues<CSSSpringTimingFunctionValue>(*this, other);
@@ -296 +294 @@
     case StepsTimingFunctionClass:
         return downcast<CSSStepsTimingFunctionValue>(*this).customCSSText();
-    case FramesTimingFunctionClass:
-        return downcast<CSSFramesTimingFunctionValue>(*this).customCSSText();
     case SpringTimingFunctionClass:
         return downcast<CSSSpringTimingFunctionValue>(*this).customCSSText();
@@ -416 +412 @@
         delete downcast<CSSStepsTimingFunctionValue>(this);
         return;
-    case FramesTimingFunctionClass:
-        delete downcast<CSSFramesTimingFunctionValue>(this);
-        return;
     case SpringTimingFunctionClass:
         delete downcast<CSSSpringTimingFunctionValue>(this);