Changeset 237047 in webkit for trunk/Source/JavaScriptCore/ChangeLog

Timestamp:

Oct 11, 2018, 2:22:40 PM (7 years ago)

Author:

Keith Rollin

Message:

CURRENT_ARCH should not be used in Run Script phase.
​https://bugs.webkit.org/show_bug.cgi?id=190407
<rdar://problem/45133556>

Reviewed by Alexey Proskuryakov.

CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
CURRENT_ARCH is not well-defined during this phase (and may even have
the value "undefined") since this phase is run just once per build
rather than once per supported architecture. Migrate away from
CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
performing an operation for each value, or by picking the first entry
in ARCHS and using that as a representative value.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj: Store

LLIntDesiredOffsets.h into a directory with a name based on ARCHS
rather than CURRENT_ARCH.

Source/WebCore:

No new tests -- no functional changes.

• DerivedSources.make: When forming TARGET_TRIPLE_FLAGS, grab the

first entry in ARCHS rather than use CURRENT_ARCH.

Source/WebKit:

• DerivedSources.make: When forming TARGET_TRIPLE_FLAGS, grab the

first entry in ARCHS rather than use CURRENT_ARCH.

Source/WebKitLegacy:

• WebKitLegacy.xcodeproj/project.pbxproj: When generating

WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
macosx platforms.

Source/WebKitLegacy/mac:

• Configurations/WebKitLegacy.xcconfig: When generating

WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
macosx platforms.

• MigrateHeaders.make:
• migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,

generate one for each architecture in ARCHS.

File:

• trunk/Source/JavaScriptCore/ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-10-11  Keith Rollin  <[email protected]>
+
+        CURRENT_ARCH should not be used in Run Script phase.
+        https://bugs.webkit.org/show_bug.cgi?id=190407
+        <rdar://problem/45133556>
+
+        Reviewed by Alexey Proskuryakov.
+
+        CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
+        CURRENT_ARCH is not well-defined during this phase (and may even have
+        the value "undefined") since this phase is run just once per build
+        rather than once per supported architecture. Migrate away from
+        CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
+        performing an operation for each value, or by picking the first entry
+        in ARCHS and using that as a representative value.
+
+        * JavaScriptCore.xcodeproj/project.pbxproj: Store
+        LLIntDesiredOffsets.h into a directory with a name based on ARCHS
+        rather than CURRENT_ARCH.
+
 2018-10-10  Mark Lam  <[email protected]>