Ignore:
Timestamp:
Oct 26, 2018, 12:33:55 PM (7 years ago)
Author:
[email protected]
Message:

Unreviewed, rolling out r237445.
​https://bugs.webkit.org/show_bug.cgi?id=190972

Cause performance regression on iOS devices (Requested by
yusukesuzuki on #webkit).

Reverted changeset:

"Unreviewed, partial rolling in r237254"
​https://bugs.webkit.org/show_bug.cgi?id=190340
​https://trac.webkit.org/changeset/237445

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/runtime/CodeCache.cpp

    r237445 r237478  
    5858        derivedContextType, evalContextType, isArrowFunctionContext, debuggerMode,
    5959        vm.typeProfiler() ? TypeProfilerEnabled::Yes : TypeProfilerEnabled::No,
    60         vm.controlFlowProfiler() ? ControlFlowProfilerEnabled::Yes : ControlFlowProfilerEnabled::No,
    61         std::nullopt);
     60        vm.controlFlowProfiler() ? ControlFlowProfilerEnabled::Yes : ControlFlowProfilerEnabled::No);
    6261    SourceCodeValue* cache = m_sourceCode.findCacheAndUpdateAge(key);
    6362    if (cache && Options::useCodeCache()) {
    … …  
    9796}
    9897
    99 UnlinkedFunctionExecutable* CodeCache::getUnlinkedGlobalFunctionExecutable(VM& vm, const Identifier& name, const SourceCode& source, DebuggerMode debuggerMode, std::optional<int> functionConstructorParametersEndPosition, ParserError& error)
     98UnlinkedFunctionExecutable* CodeCache::getUnlinkedGlobalFunctionExecutable(VM& vm, const Identifier& name, const SourceCode& source, DebuggerMode debuggerMode, ParserError& error)
    10099{
    101100    bool isArrowFunctionContext = false;
    … …  
    109108        debuggerMode,
    110109        vm.typeProfiler() ? TypeProfilerEnabled::Yes : TypeProfilerEnabled::No,
    111         vm.controlFlowProfiler() ? ControlFlowProfilerEnabled::Yes : ControlFlowProfilerEnabled::No,
    112         functionConstructorParametersEndPosition);
     110        vm.controlFlowProfiler() ? ControlFlowProfilerEnabled::Yes : ControlFlowProfilerEnabled::No);
    113111    SourceCodeValue* cache = m_sourceCode.findCacheAndUpdateAge(key);
    114112    if (cache && Options::useCodeCache()) {
Note: See TracChangeset for help on using the changeset viewer.