Changeset 238439 in webkit for trunk/Source/JavaScriptCore/offlineasm/arm.rb

Timestamp:

Nov 21, 2018, 9:47:05 PM (7 years ago)

Author:

[email protected]

Message:

[JSC] Drop ARM_TRADITIONAL support in LLInt, baseline JIT, and DFG
​https://bugs.webkit.org/show_bug.cgi?id=191675

Reviewed by Mark Lam.

Source/JavaScriptCore:

We no longer maintain ARM_TRADITIONAL LLInt and JIT in JSC. This architecture will use
CLoop instead. This patch removes ARM_TRADITIONAL support in LLInt and JIT.

Discussed in ​https://lists.webkit.org/pipermail/webkit-dev/2018-October/030220.html.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• assembler/ARMAssembler.cpp: Removed.
• assembler/ARMAssembler.h: Removed.
• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::dumpCode):

• assembler/MacroAssembler.h:

(JSC::MacroAssembler::patchableBranch32):

• assembler/MacroAssemblerARM.cpp: Removed.
• assembler/MacroAssemblerARM.h: Removed.
• assembler/PerfLog.cpp:
• assembler/PerfLog.h:
• assembler/ProbeContext.h:

(JSC::Probe::CPUState::pc):
(JSC::Probe::CPUState::fp):
(JSC::Probe::CPUState::sp):

• assembler/testmasm.cpp:

(JSC::isPC):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):

• bytecode/InlineAccess.h:

(JSC::InlineAccess::sizeForPropertyAccess):
(JSC::InlineAccess::sizeForPropertyReplace):
(JSC::InlineAccess::sizeForLengthAccess):

• dfg/DFGSpeculativeJIT.h:
• disassembler/CapstoneDisassembler.cpp:

(JSC::tryToDisassemble):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::debugCall):

• jit/AssemblyHelpers.h:
• jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsImpl):
(JSC::CCallHelpers::prepareForTailCallSlow):

• jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::prepareForTailCall):

• jit/HostCallReturnValue.cpp:
• jit/JITMathIC.h:

(JSC::isProfileEmpty):

• jit/RegisterSet.cpp:

(JSC::RegisterSet::reservedHardwareRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):

• jit/Repatch.cpp:

(JSC::forceICFailure):

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

• llint/LLIntOfflineAsmConfig.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• offlineasm/arm.rb:
• offlineasm/backends.rb:
• yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):

Source/WTF:

• wtf/InlineASM.h:
• wtf/Platform.h:

File:

• trunk/Source/JavaScriptCore/offlineasm/arm.rb (modified) (4 diffs)

trunk/Source/JavaScriptCore/offlineasm/arm.rb

@@ -60 +60 @@
     when "ARMv7"
         true
-    when "ARMv7_TRADITIONAL", "ARM"
-        false
-    else
-        raise "bad value for $activeBackend: #{$activeBackend}"
-    end
-end
-
-def isARMv7Traditional
-    case $activeBackend
-    when "ARMv7_TRADITIONAL"
-        true
-    when "ARMv7", "ARM"
-        false
     else
         raise "bad value for $activeBackend: #{$activeBackend}"
@@ -105 +92 @@
     elsif (~value) >= 0 && (~value) < 256
         $asm.puts "mvn #{register.armOperand}, \##{~value}"
-    elsif isARMv7 or isARMv7Traditional
+    elsif isARMv7
         $asm.puts "movw #{register.armOperand}, \##{value & 0xffff}"
         if (value & 0xffff0000) != 0
@@ -302 +289 @@
 
 class Sequence
-    def getModifiedListARM
-        raise unless $activeBackend == "ARM"
-        getModifiedListARMCommon
-    end
-
     def getModifiedListARMv7
         raise unless $activeBackend == "ARMv7"
-        getModifiedListARMCommon
-    end
-
-    def getModifiedListARMv7_TRADITIONAL
-        raise unless $activeBackend == "ARMv7_TRADITIONAL"
         getModifiedListARMCommon
     end
@@ -415 +392 @@
 
 class Instruction
-    def lowerARM
-        raise unless $activeBackend == "ARM"
-        lowerARMCommon
-    end
-
     def lowerARMv7
         raise unless $activeBackend == "ARMv7"
-        lowerARMCommon
-    end
-
-    def lowerARMv7_TRADITIONAL
-        raise unless $activeBackend == "ARMv7_TRADITIONAL"
         lowerARMCommon
     end