Changeset 23846 in webkit for trunk/JavaScriptCore/pcre/pcre_compile.c

Timestamp:

Jun 27, 2007, 11:53:45 PM (18 years ago)

Author:

kmccullo

Message:

JavaScriptCore:

Reviewed by Darin.

• <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
• Correctly evaluate the return value of _pcre_ucp_findchar.

• pcre/pcre_compile.c: (compile_branch):
• pcre/pcre_exec.c: (match):

LayoutTests:

Reviewed by Darin.

• <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
• Correctly evaluate the return value of _pcre_ucp_findchar.

• fast/js/regexp-unicode-overflow-expected.txt: Added.
• fast/js/regexp-unicode-overflow.html: Added.
• fast/js/resources/regexp-unicode-overflow.js: Added.

File:

• trunk/JavaScriptCore/pcre/pcre_compile.c (modified) (1 diff)

trunk/JavaScriptCore/pcre/pcre_compile.c

@@ -2193 +2193 @@
           int chartype;
           int othercase;
-          if (_pcre_ucp_findchar(c, &chartype, &othercase) >= 0 &&
+          if (_pcre_ucp_findchar(c, &chartype, &othercase) == ucp_L &&
                othercase > 0)
             {