Changeset 238650 in webkit for trunk/Source/JavaScriptCore/config.h

Timestamp:

Nov 28, 2018, 5:22:19 PM (6 years ago)

Author:

[email protected]

Message:

ENABLE_SEPARATED_WX_HEAP needs to be defined in Platform.h.
​https://bugs.webkit.org/show_bug.cgi?id=192110
<rdar://problem/46317746>

Reviewed by Saam Barati.

Source/JavaScriptCore:

• config.h:

Source/WTF:

Contrary my previous claim in r238564, ENABLE_SEPARATED_WX_HEAP needs to be
defined in Platform.h because it is also needed in WebCore for the CSS JIT. Also
contrary to my previous claim, ENABLE(FAST_JIT_PERMISSIONS) is defined for WebCore
(and other projects) as well as JSC. Hence, there's no reason why
ENABLE_SEPARATED_WX_HEAP cannot be defined in Platform.h.

• wtf/Platform.h:

File:

• trunk/Source/JavaScriptCore/config.h (modified) (1 diff)

trunk/Source/JavaScriptCore/config.h

@@ -38 +38 @@
 
 #include <wtf/DisallowCType.h>
-
-#if !defined(ENABLE_SEPARATED_WX_HEAP)
-#if (!ENABLE(FAST_JIT_PERMISSIONS) || !CPU(ARM64E)) && PLATFORM(IOS_FAMILY) && CPU(ARM64)
-#define ENABLE_SEPARATED_WX_HEAP 1
-#else
-#define ENABLE_SEPARATED_WX_HEAP 0
-#endif
-#endif // !defined(ENABLE_SEPARATED_WX_HEAP)