Changeset 239013 in webkit for trunk/Source/JavaScriptCore/runtime/PropertySlot.h

Timestamp:

Dec 8, 2018, 3:53:29 PM (6 years ago)

Author:

[email protected]

Message:

Reduce size of PropertySlot and PutPropertySlot.
​https://bugs.webkit.org/show_bug.cgi?id=192526

Reviewed by Keith Miller.

With some minor adjustments, we can reduce the size of PropertySlot from 80 bytes
(19 padding bytes) to 64 bytes (3 padding bytes), and PutPropertySlot from 40
bytes (4 padding bytes) to 32 bytes (0 padding bytes but with 6 unused bits).
These measurements are for a 64-bit build.

• runtime/PropertySlot.h:
• runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::PutPropertySlot):

File:

• trunk/Source/JavaScriptCore/runtime/PropertySlot.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/runtime/PropertySlot.h

@@ -371 +371 @@
     JS_EXPORT_PRIVATE JSValue customAccessorGetter(ExecState*, PropertyName) const;
 
-    unsigned m_attributes;
     union {
         EncodedJSValue value;
@@ -385 +384 @@
     } m_data;
 
+    unsigned m_attributes;
     PropertyOffset m_offset;
     JSValue m_thisValue;
@@ -393 +393 @@
     InternalMethodType m_internalMethodType;
     AdditionalDataType m_additionalDataType;
+    bool m_isTaintedByOpaqueObject;
     union {
         DOMAttributeAnnotation domAttribute;
         ModuleNamespaceSlot moduleNamespaceSlot;
     } m_additionalData;
-    bool m_isTaintedByOpaqueObject;
 };