Changeset 239231 in webkit for trunk/Source/JavaScriptCore/dfg/DFGNode.cpp

Timestamp:

Dec 14, 2018, 1:40:27 PM (6 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r239153, r239154, and r239155.
​https://bugs.webkit.org/show_bug.cgi?id=192715

Caused flaky GC-related crashes seen with layout tests
(Requested by ryanhaddad on #webkit).

Reverted changesets:

"[JSC] Optimize Object.keys by caching own keys results in
StructureRareData"
​https://bugs.webkit.org/show_bug.cgi?id=190047
​https://trac.webkit.org/changeset/239153

"Unreviewed, build fix after r239153"
​https://bugs.webkit.org/show_bug.cgi?id=190047
​https://trac.webkit.org/changeset/239154

"Unreviewed, build fix after r239153, part 2"
​https://bugs.webkit.org/show_bug.cgi?id=190047
​https://trac.webkit.org/changeset/239155

File:

• trunk/Source/JavaScriptCore/dfg/DFGNode.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGNode.cpp

@@ -32 +32 @@
 #include "DFGPromotedHeapLocation.h"
 #include "JSCInlines.h"
-#include "JSImmutableButterfly.h"
 
 namespace JSC { namespace DFG {
@@ -225 +224 @@
 }
 
-void Node::convertToNewArrayBuffer(FrozenValue* immutableButterfly)
-{
-    setOpAndDefaultFlags(NewArrayBuffer);
-    NewArrayBufferData data { };
-    data.indexingMode = immutableButterfly->cast<JSImmutableButterfly*>()->indexingMode();
-    data.vectorLengthHint = immutableButterfly->cast<JSImmutableButterfly*>()->toButterfly()->vectorLength();
-    children.reset();
-    m_opInfo = immutableButterfly;
-    m_opInfo2 = data.asQuadWord;
-}
-
 void Node::convertToDirectCall(FrozenValue* executable)
 {