Changeset 239273 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Dec 17, 2018, 10:45:16 AM (6 years ago)

Author:

Matt Lewis

Message:

Unreviewed, rolling out r239254.

This broke the Windows 10 Debug build

Reverted changeset:

"Replace many uses of String::format with more type-safe
alternatives"
​https://bugs.webkit.org/show_bug.cgi?id=192742
​https://trac.webkit.org/changeset/239254

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -90 +90 @@
 #include <wtf/WallTime.h>
 #include <wtf/text/StringBuilder.h>
-#include <wtf/text/StringConcatenateNumbers.h>
 
 #if OS(WINDOWS)
@@ -1166 +1165 @@
     StackVisitor::Status operator()(StackVisitor& visitor) const
     {
-        m_trace.append(makeString("    ", visitor->index(), "   ", visitor->toString(), '\n'));
+        m_trace.append(String::format("    %zu   %s\n", visitor->index(), visitor->toString().utf8().data()));
         return StackVisitor::Continue;
     }