Ignore:
Timestamp:
Jan 28, 2019, 8:33:33 PM (6 years ago)
Author:
[email protected]
Message:

[JSC] Reduce size of memory used for ShadowChicken
https://bugs.webkit.org/show_bug.cgi?id=193546

Reviewed by Mark Lam.

This patch lazily instantiate ShadowChicken. We do not need this until we start logging ShadowChicken packets.
The removal of ShadowChicken saves 55KB memory.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::create):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::ensureShadowChickenPacket):

  • heap/Heap.cpp:

(JSC::Heap::stopThePeriphery):
(JSC::Heap::addCoreConstraints):

  • jit/CCallHelpers.cpp:

(JSC::CCallHelpers::ensureShadowChickenPacket):

  • jit/JITExceptions.cpp:

(JSC::genericUnwind):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

  • jit/JITOperations.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::setDebugger):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::setDebugger): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::ensureShadowChicken):

  • runtime/VM.h:

(JSC::VM::shadowChicken):

  • tools/JSDollarVM.cpp:

(JSC::functionShadowChickenFunctionsOnStack):
(JSC::changeDebuggerModeWhenIdle):

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r240633 r240637  
     12019-01-28  Yusuke Suzuki  <[email protected]>
     2
     3        [JSC] Reduce size of memory used for ShadowChicken
     4        https://bugs.webkit.org/show_bug.cgi?id=193546
     5
     6        Reviewed by Mark Lam.
     7
     8        This patch lazily instantiate ShadowChicken. We do not need this until we start logging ShadowChicken packets.
     9        The removal of ShadowChicken saves 55KB memory.
     10
     11        * debugger/DebuggerCallFrame.cpp:
     12        (JSC::DebuggerCallFrame::create):
     13        * ftl/FTLLowerDFGToB3.cpp:
     14        (JSC::FTL::DFG::LowerDFGToB3::ensureShadowChickenPacket):
     15        * heap/Heap.cpp:
     16        (JSC::Heap::stopThePeriphery):
     17        (JSC::Heap::addCoreConstraints):
     18        * jit/CCallHelpers.cpp:
     19        (JSC::CCallHelpers::ensureShadowChickenPacket):
     20        * jit/JITExceptions.cpp:
     21        (JSC::genericUnwind):
     22        * jit/JITOpcodes.cpp:
     23        (JSC::JIT::emit_op_log_shadow_chicken_prologue):
     24        (JSC::JIT::emit_op_log_shadow_chicken_tail):
     25        * jit/JITOpcodes32_64.cpp:
     26        (JSC::JIT::emit_op_log_shadow_chicken_prologue):
     27        (JSC::JIT::emit_op_log_shadow_chicken_tail):
     28        * jit/JITOperations.cpp:
     29        * llint/LLIntSlowPaths.cpp:
     30        (JSC::LLInt::LLINT_SLOW_PATH_DECL):
     31        * runtime/JSGlobalObject.cpp:
     32        (JSC::JSGlobalObject::setDebugger):
     33        * runtime/JSGlobalObject.h:
     34        (JSC::JSGlobalObject::setDebugger): Deleted.
     35        * runtime/VM.cpp:
     36        (JSC::VM::VM):
     37        (JSC::VM::ensureShadowChicken):
     38        * runtime/VM.h:
     39        (JSC::VM::shadowChicken):
     40        * tools/JSDollarVM.cpp:
     41        (JSC::functionShadowChickenFunctionsOnStack):
     42        (JSC::changeDebuggerModeWhenIdle):
     43
    1442019-01-28  Andy Estes  <[email protected]>
    245
Note: See TracChangeset for help on using the changeset viewer.