Changeset 240637 in webkit for trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp

Timestamp:

Jan 28, 2019, 8:33:33 PM (7 years ago)

Author:

[email protected]

Message:

[JSC] Reduce size of memory used for ShadowChicken
​https://bugs.webkit.org/show_bug.cgi?id=193546

Reviewed by Mark Lam.

This patch lazily instantiate ShadowChicken. We do not need this until we start logging ShadowChicken packets.
The removal of ShadowChicken saves 55KB memory.

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::create):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::ensureShadowChickenPacket):

• heap/Heap.cpp:

(JSC::Heap::stopThePeriphery):
(JSC::Heap::addCoreConstraints):

• jit/CCallHelpers.cpp:

(JSC::CCallHelpers::ensureShadowChickenPacket):

• jit/JITExceptions.cpp:

(JSC::genericUnwind):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

• jit/JITOperations.cpp:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::setDebugger):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::setDebugger): Deleted.

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::ensureShadowChicken):

• runtime/VM.h:

(JSC::VM::shadowChicken):

• tools/JSDollarVM.cpp:

(JSC::functionShadowChickenFunctionsOnStack):
(JSC::changeDebuggerModeWhenIdle):

File:

• trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp

@@ -71 +71 @@
 
     Vector<ShadowChicken::Frame> frames;
-    vm.shadowChicken().iterate(vm, callFrame, [&] (const ShadowChicken::Frame& frame) -> bool {
+    vm.ensureShadowChicken();
+    vm.shadowChicken()->iterate(vm, callFrame, [&] (const ShadowChicken::Frame& frame) -> bool {
         frames.append(frame);
         return true;