Changeset 240644 in webkit for trunk/Source/JavaScriptCore/ChangeLog

Timestamp:

Jan 28, 2019, 10:20:56 PM (6 years ago)

Author:

Devin Rousso

Message:

Web Inspector: provide a way to edit page WebRTC settings on a remote target
​https://bugs.webkit.org/show_bug.cgi?id=193863
<rdar://problem/47572764>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/Page.json:

Add more values to the Setting enum type:

• ICECandidateFilteringEnabled
• MediaCaptureRequiresSecureConnection
• MockCaptureDevicesEnabled

Source/WebCore:

Test: inspector/page/overrideSetting-ICECandidateFilteringEnabled.html

inspector/page/overrideSetting-MockCaptureDevicesEnabled.html

• inspector/agents/InspectorPageAgent.cpp:

• page/Settings.yaml:
• page/SettingsBase.h:
• page/SettingsBase.cpp:

(SettingsBase::iceCandidateFilteringEnabledChanged): Added.
(SettingsBase::mockCaptureDevicesEnabledChanged): Added.

• Scripts/GenerateSettings.rb:
• Scripts/SettingsTemplates/Settings.cpp.erb:

Add page-level settings for WebRTC preferences.

• Modules/mediastream/UserMediaController.cpp:

(WebCore::UserMediaController::canCallGetUserMedia):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMediaCaptureRequiresSecureConnection):

• testing/Internals.h:
• testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setMockMediaCaptureDevicesEnabled):
(WebCore::Internals::setMediaCaptureRequiresSecureConnection): Added.

• page/DeprecatedGlobalSettings.h:
• page/DeprecatedGlobalSettings.cpp:

(WebCore::DeprecatedGlobalSettings::mockCaptureDevicesEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setMockCaptureDevicesEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::mediaCaptureRequiresSecureConnection): Deleted.
(WebCore::DeprecatedGlobalSettings::setMediaCaptureRequiresSecureConnection): Deleted.

Source/WebInspectorUI:

• UserInterface/Base/Main.js:

(WI.loaded):
(WI.initializeTarget):
(WI._handleDeviceSettingsToolbarButtonClicked):
(WI._handleDeviceSettingsToolbarButtonClicked.createCheckbox):
(WI._handleDeviceSettingsToolbarButtonClicked.createColumns): Deleted.

• UserInterface/Views/Main.css:

(.device-settings-content .container): Added.

• Localizations/en.lproj/localizedStrings.js:

Source/WebKit:

• Shared/WebPreferences.yaml:

Add page-level settings for WebRTC preferences.

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Add page-level settings for WebRTC preferences.

LayoutTests:

• inspector/page/overrideSetting-ICECandidateFilteringEnabled.html: Added.
• inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt: Added.
• inspector/page/overrideSetting-MockCaptureDevicesEnabled.html: Added.
• inspector/page/overrideSetting-MockCaptureDevicesEnabled-expected.txt: Added.
• platform/mac/TestExpectations:

File:

• trunk/Source/JavaScriptCore/ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-01-28  Devin Rousso  <[email protected]>
+
+        Web Inspector: provide a way to edit page WebRTC settings on a remote target
+        https://bugs.webkit.org/show_bug.cgi?id=193863
+        <rdar://problem/47572764>
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/protocol/Page.json:
+        Add more values to the `Setting` enum type:
+         - `ICECandidateFilteringEnabled`
+         - `MediaCaptureRequiresSecureConnection`
+         - `MockCaptureDevicesEnabled`
+
 2019-01-28  Ross Kirsling  <[email protected]>