Changeset 241335 in webkit for trunk/Source/JavaScriptCore/b3/B3Value.cpp

Timestamp:

Feb 12, 2019, 6:30:13 PM (6 years ago)

Author:

[email protected]

Message:

Make B3Value::returnsBool() more precise
​https://bugs.webkit.org/show_bug.cgi?id=194457

Reviewed by Saam Barati.

It is currently used repeatedly in B3ReduceStrength, as well as once in B3LowerToAir.
It has a needlessly complex rule for BitAnd, and has no rule for other easy cases such as BitOr or Select.
No new tests added as this should be indirectly tested by the already existing tests.

• b3/B3Value.cpp:

(JSC::B3::Value::returnsBool const):

File:

• trunk/Source/JavaScriptCore/b3/B3Value.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/b3/B3Value.cpp

@@ -500 +500 @@
         return asInt32() == 0 || asInt32() == 1;
     case BitAnd:
-        return child(1)->isInt32(1)
-            || (child(0)->returnsBool() && child(1)->hasInt() && child(1)->asInt() & 1);
+        return child(0)->returnsBool() || child(1)->returnsBool();
+    case BitOr:
+    case BitXor:
+        return child(0)->returnsBool() && child(1)->returnsBool();
+    case Select:
+        return child(1)->returnsBool() && child(2)->returnsBool();
+    case Identity:
+        return child(0)->returnsBool();
     case Equal:
     case NotEqual: