Changeset 241640 in webkit for trunk/Source/JavaScriptCore/runtime/RegExpCache.cpp

Timestamp:

Feb 15, 2019, 8:32:42 PM (7 years ago)

Author:

[email protected]

Message:

[JSC] Lazily create empty RegExp
​https://bugs.webkit.org/show_bug.cgi?id=194735

Reviewed by Keith Miller.

Some scripts do not have any RegExp. In that case, allocating MarkedBlock for RegExp is costly.
Previously, there was always one RegExp, "empty RegExp". This patch lazily creates it and drop
one MarkedBlock.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/RegExpCache.cpp:

(JSC::RegExpCache::ensureEmptyRegExpSlow):
(JSC::RegExpCache::initialize): Deleted.

• runtime/RegExpCache.h:

(JSC::RegExpCache::ensureEmptyRegExp):
(JSC::RegExpCache::emptyRegExp const): Deleted.

• runtime/RegExpCachedResult.cpp:

(JSC::RegExpCachedResult::lastResult):

• runtime/RegExpCachedResult.h:
• runtime/VM.cpp:

(JSC::VM::VM):

File:

• trunk/Source/JavaScriptCore/runtime/RegExpCache.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/RegExpCache.cpp

@@ -57 +57 @@
 }
 
-void RegExpCache::initialize(VM& vm)
+RegExp* RegExpCache::ensureEmptyRegExpSlow(VM& vm)
 {
-    m_emptyRegExp.set(vm, RegExp::create(vm, "", NoFlags));
+    RegExp* regExp = RegExp::create(vm, "", NoFlags);
+    m_emptyRegExp.set(vm, regExp);
+    return regExp;
 }