Changeset 243609 in webkit for trunk/Source/JavaScriptCore/parser/SourceCodeKey.h

Timestamp:

Mar 28, 2019, 10:50:19 AM (6 years ago)

Author:

Tadeu Zagallo

Message:

In-memory code cache should not share bytecode across domains
​https://bugs.webkit.org/show_bug.cgi?id=196321

Reviewed by Geoffrey Garen.

Use the SourceProvider's URL to make sure that the hosts match for the
two SourceCodeKeys in operator==.

• parser/SourceCodeKey.h:

(JSC::SourceCodeKey::host const):
(JSC::SourceCodeKey::operator== const):

File:

• trunk/Source/JavaScriptCore/parser/SourceCodeKey.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/SourceCodeKey.h

@@ -111 +111 @@
     StringView string() const { return m_sourceCode.view(); }
 
+    StringView host() const { return m_sourceCode.provider().url().host(); }
+
     bool operator==(const SourceCodeKey& other) const
     {
@@ -118 +120 @@
             && m_functionConstructorParametersEndPosition == other.m_functionConstructorParametersEndPosition
             && m_name == other.m_name
+            && host() == other.host()
             && string() == other.string();
     }