Changeset 243697 in webkit for trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp

Timestamp:

Apr 1, 2019, 10:27:53 AM (6 years ago)

Author:

Michael Catanzaro

Message:

Stop trying to support building JSC with clang 3.8
​https://bugs.webkit.org/show_bug.cgi?id=195947
<rdar://problem/49069219>

Reviewed by Darin Adler.

It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
don't know how much effort it would be to make JSC work again, and it's making the code
Source/JavaScriptCore:

worse. Remove my hacks to support clang 3.8 from JSC.

• bindings/ScriptValue.cpp:

(Inspector::jsToInspectorValue):

• bytecode/GetterSetterAccessCase.cpp:

(JSC::GetterSetterAccessCase::create):
(JSC::GetterSetterAccessCase::clone const):

• bytecode/InstanceOfAccessCase.cpp:

(JSC::InstanceOfAccessCase::clone const):

• bytecode/IntrinsicGetterAccessCase.cpp:

(JSC::IntrinsicGetterAccessCase::clone const):

• bytecode/ModuleNamespaceAccessCase.cpp:

(JSC::ModuleNamespaceAccessCase::clone const):

• bytecode/ProxyableAccessCase.cpp:

(JSC::ProxyableAccessCase::clone const):

Source/WTF:

worse. Remove my hacks to support clang 3.8 from WTF.

• wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::allocate):

• wtf/text/StringConcatenate.h:

(WTF::tryMakeStringFromAdapters):

File:

• trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp

@@ -75 +75 @@
                 inspectorArray->pushValue(WTFMove(elementValue));
             }
-            return RefPtr<JSON::Value> { WTFMove(inspectorArray) };
+            return inspectorArray;
         }
         VM& vm = scriptState.vm();
@@ -88 +88 @@
             inspectorObject->setValue(name.string(), WTFMove(inspectorValue));
         }
-        return RefPtr<JSON::Value> { WTFMove(inspectorObject) };
+        return inspectorObject;
     }