Changeset 24394 in webkit for trunk/JavaScriptCore/kjs/function.h

Timestamp:

Jul 17, 2007, 7:25:38 PM (18 years ago)

Author:

darin

Message:

JavaScriptCore:

Reviewed by Darin, Maciej, and Adam.

Fixes <​http://bugs.webkit.org/show_bug.cgi?id=9697>,

the failure of ecma/GlobalObject/15.1.2.2-2.js,
the failure of ecma/LexicalConventions/7.7.3-1.js,
and most of the failures of tests in ecma/TypeConversion/9.3.1-3.js.

Bug 9697: parseInt results may be inaccurate for numbers greater than 2⁵³

This patch also fixes similar issues in the lexer and UString::toDouble().

• kjs/function.cpp: (KJS::parseIntOverflow): (KJS::parseInt):
• kjs/function.h:
• kjs/lexer.cpp: (KJS::Lexer::lex):
• kjs/ustring.cpp: (KJS::UString::toDouble):
• tests/mozilla/expected.html:

LayoutTests:

Reviewed by Darin.

Added tests for:
​http://bugs.webkit.org/show_bug.cgi?id=9697

Bug 9697: parseInt results may be inaccurate for numbers greater than 2⁵³

• fast/js/numeric-conversion-expected.txt: Added.
• fast/js/numeric-conversion.html: Added.
• fast/js/resources/numeric-conversion.js: Added.

File:

• trunk/JavaScriptCore/kjs/function.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/function.h

@@ -233 +233 @@
   };
 
+  static const double mantissaOverflowLowerBound = 9007199254740992.0;
+  double parseIntOverflow(const char* s, int length, int radix);
+
 UString escapeStringForPrettyPrinting(const UString& s);