Changeset 245295 in webkit for trunk/Source/WebCore/css/CSSGridAutoRepeatValue.cpp

Timestamp:

May 14, 2019, 12:06:23 PM (6 years ago)

Author:

Oriol Brufau

Message:

[css-grid] Update grid when changing auto repeat type
​https://bugs.webkit.org/show_bug.cgi?id=197849

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Import WPT test.

• web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks-expected.txt: Added.
• web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html: Added.
• web-platform-tests/css/css-grid/grid-definition/w3c-import.log:

Source/WebCore:

Test: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html

This patch makes two 'repeat()' values for 'grid-template' be considered
to be different if one uses 'auto-fill' and the other 'auto-fit'.

Previously, they were considered to be equal if the repeated values
were the same, without comparing the repeat type. Therefore, the grid
was not updated when setting both values one after the other.

• css/CSSGridAutoRepeatValue.cpp:

(WebCore::CSSGridAutoRepeatValue::equals const):

• css/CSSGridAutoRepeatValue.h:

LayoutTests:

Remove the test which has been upstreamed to WPT.

• fast/css-grid-layout/grid-change-auto-repeat-tracks-expected.txt: Removed.
• fast/css-grid-layout/grid-change-auto-repeat-tracks.html: Removed.

File:

• trunk/Source/WebCore/css/CSSGridAutoRepeatValue.cpp (modified) (1 diff)

trunk/Source/WebCore/css/CSSGridAutoRepeatValue.cpp

@@ -47 +47 @@
 }
 
+bool CSSGridAutoRepeatValue::equals(const CSSGridAutoRepeatValue& other) const
+{
+    return m_autoRepeatID == other.m_autoRepeatID && CSSValueList::equals(other);
+}
+
 } // namespace WebCore