Changeset 2475 in webkit for trunk/JavaScriptCore/kjs/array_object.cpp

Timestamp:

Oct 25, 2002, 10:49:57 PM (23 years ago)

Author:

darin

Message:

• fixed 3038011 -- drop-down menu hierarchy broken at yahoo new acct page

• kjs/array_object.cpp: (ArrayProtoFuncImp::call): Fix bug calling concat on an empty array. The old code tried to optimize in a way that would prevent appending any arrays until at least one element was in the destination array. So if you were concatenating a non-empty array into an empty array, you got an empty array.

File:

• trunk/JavaScriptCore/kjs/array_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -291 +291 @@
           curObj.inherits(&ArrayInstanceImp::info)) {
         unsigned int k = 0;
-        if (n > 0)
-          length = curObj.get(exec,lengthPropertyName).toUInt32(exec);
+        // Older versions tried to optimize out getting the length of thisObj
+        // by checking for n != 0, but that doesn't work if thisObj is an empty array.
+        length = curObj.get(exec,lengthPropertyName).toUInt32(exec);
         while (k < length) {
           if (curObj.hasProperty(exec,k))