Changeset 248552 in webkit for trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp

Timestamp:

Aug 12, 2019, 4:09:06 PM (6 years ago)

Author:

[email protected]

Message:

Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
​https://bugs.webkit.org/show_bug.cgi?id=200614

Reviewed by Darin Adler.

Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and
StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).

Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to
StringBuilder::appendSubstring(...).

Source/JavaScriptCore:

• dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

• runtime/ConfigFile.cpp:

(JSC::ConfigFile::parse):

• runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lexStringSlow):

• tools/FunctionOverrides.cpp:

(JSC::parseClause):
Update for renames.

Source/WebCore:

• dom/Range.cpp:

(WebCore::Range::toString const):

• editing/Editing.cpp:

(WebCore::stringWithRebalancedWhitespace):

• editing/MarkupAccumulator.cpp:

(WebCore::appendCharactersReplacingEntitiesInternal):

• editing/TextIterator.cpp:

(WebCore::TextIteratorCopyableText::appendToStringBuilder const):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks const):

• html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::bufferedCharacters const):

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processNativeSamples):

• platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::Substring::appendTo const):

• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::decode):

• xml/XSLTProcessorLibxslt.cpp:

(WebCore::writeToStringBuilder):
Update for renames.

Source/WebKit:

• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::setAndSerializeSandboxParameters):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::didReceiveInvalidMessage):
Update for renames.

Source/WTF:

• wtf/HexNumber.h:

(WTF::appendUnsignedAsHexFixedSize):
Add overload that explicitly takes a StringBuilder to work around rename from append to appendCharacters.

• wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendCharacters):
(WTF::StringBuilder::append):

• wtf/text/StringBuilder.h:

(WTF::StringBuilder::appendCharacters):
(WTF::StringBuilder::append):
(WTF::StringBuilder::appendSubstring):
(WTF::StringBuilder::appendLiteral):
(WTF::IntegerToStringConversionTrait<StringBuilder>::flush):
Update for renames.

Tools:

• TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):
Update for renames.

File:

• trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/tools/FunctionOverrides.cpp

@@ -218 +218 @@
                 FAIL_WITH_ERROR(SYNTAX_ERROR, ("Unexpected characters after '", keyword, "' clause end delimiter '", delimiter, "':\n", line, "\n"));
 
-            builder.append(line, p - line + 1);
+            builder.appendCharacters(line, p - line + 1);
             return builder.toString();
         }