Changeset 248738 in webkit for trunk/Source/JavaScriptCore/runtime/DateConversion.cpp

Timestamp:

Aug 15, 2019, 12:31:13 PM (6 years ago)

Author:

[email protected]

Message:

DateConversion::formatDateTime incorrectly formats negative years
​https://bugs.webkit.org/show_bug.cgi?id=199964

Patch by Alexey Shvayka <Alexey Shvayka> on 2019-08-15
Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml: Mark 6 test cases as passing.

Source/JavaScriptCore:

Currently, year is always padded to max length of 4, including the minus sign "-".
With this change, only absolute value of year is padded to max length of 4 and
preceded by minus sign "-" if the year is negative.
(steps 6-10 of ​https://tc39.es/ecma262/#sec-datestring)

• runtime/DateConversion.cpp:

(JSC::appendNumber):

File:

• trunk/Source/JavaScriptCore/runtime/DateConversion.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/DateConversion.cpp

@@ -42 +42 @@
 static inline void appendNumber(StringBuilder& builder, int value)
 {
-    int fillingZerosCount = width;
     if (value < 0) {
         builder.append('-');
         value = -value;
-        --fillingZerosCount;
     }
     String valueString = String::number(value);
-    fillingZerosCount -= valueString.length();
+    int fillingZerosCount = width - valueString.length();
     for (int i = 0; i < fillingZerosCount; ++i)
         builder.append('0');