Changeset 249518 in webkit for trunk/Source/JavaScriptCore/tools/FunctionOverrides.h

Timestamp:

Sep 4, 2019, 7:52:46 PM (6 years ago)

Author:

[email protected]

Message:

[JSC] FunctionOverrides should have a lock to ensure concurrent access to hash table does not happen
​https://bugs.webkit.org/show_bug.cgi?id=201485

Reviewed by Tadeu Zagallo.

FunctionOverrides is a per-process singleton for registering overrides information. But we are accessing
it without taking a lock. If multiple threads with multiple VMs are accessing this concurrently, we have
a race issue like,

1. While one thread is adding overrides information,
2. Another thread is accessing this hash table.

This patch adds a lock to make sure that only one thread can access this registry.

• tools/FunctionOverrides.cpp:

(JSC::FunctionOverrides::FunctionOverrides):
(JSC::FunctionOverrides::reinstallOverrides):
(JSC::FunctionOverrides::initializeOverrideFor):
(JSC::FunctionOverrides::parseOverridesInFile):

• tools/FunctionOverrides.h:

(JSC::FunctionOverrides::clear):

File:

• trunk/Source/JavaScriptCore/tools/FunctionOverrides.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/tools/FunctionOverrides.h

@@ -28 +28 @@
 #include "SourceCode.h"
 #include <wtf/HashMap.h>
+#include <wtf/Lock.h>
 #include <wtf/text/WTFString.h>
 
@@ -57 +58 @@
 
 private:
-    void parseOverridesInFile(const char* fileName);
-    void clear() { m_entries.clear(); }
+    void parseOverridesInFile(const AbstractLocker&, const char* fileName);
+    void clear(const AbstractLocker&) { m_entries.clear(); }
 
     HashMap<String, String> m_entries;
+    Lock m_lock;
 };