Changeset 25085 in webkit for trunk/JavaScriptCore/API/JSCallbackObject.cpp

Timestamp:

Aug 14, 2007, 6:07:06 PM (18 years ago)

Author:

andrew

Message:

JavaScriptCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

• API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
• API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
• bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
• kjs/number_object.cpp: (integer_part_noexp): (char_sequence):
• kjs/ustring.cpp: (KJS::UString::UTF8String):

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::saveState):
• platform/KURL.cpp: (WebCore::KURL::KURL): (WebCore::KURL::init): (WebCore::KURL::decode_string): (WebCore::KURL::parse): (WebCore::KURL::encode_string):
• platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL):
• platform/mac/KURLMac.mm: (WebCore::KURL::KURL):
• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis):

win:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
conversions of wtf::Vector<T> to T* by explicitly calling .data()

• WebView.cpp: (getCompositionString):

File:

• trunk/JavaScriptCore/API/JSCallbackObject.cpp (modified) (2 diffs)

trunk/JavaScriptCore/API/JSCallbackObject.cpp

@@ -238 +238 @@
                 arguments[i] = toRef(args[i]);
             JSLock::DropAllLocks dropAllLocks;
-            return toJS(callAsConstructor(execRef, thisRef, argumentCount, arguments, toRef(exec->exceptionSlot())));
+            return toJS(callAsConstructor(execRef, thisRef, argumentCount, arguments.data(), toRef(exec->exceptionSlot())));
         }
     }
@@ -293 +293 @@
                 arguments[i] = toRef(args[i]);
             JSLock::DropAllLocks dropAllLocks;
-            return toJS(callAsFunction(execRef, thisRef, thisObjRef, argumentCount, arguments, toRef(exec->exceptionSlot())));
+            return toJS(callAsFunction(execRef, thisRef, thisObjRef, argumentCount, arguments.data(), toRef(exec->exceptionSlot())));
         }
     }