Changeset 251583 in webkit for trunk/Source/JavaScriptCore/profiler

Timestamp:

Oct 24, 2019, 10:45:03 PM (6 years ago)

Author:

[email protected]

Message:

REGRESSION(r251468): Build, test failures in 32-bit JSC after BytecodeIndex refactoring
​https://bugs.webkit.org/show_bug.cgi?id=203290

Reviewed by Keith Miller.

• bytecode/BytecodeIndex.h:

(JSC::BytecodeIndex::BytecodeIndex):
Add a BytecodeIndex(WTF::HashTableDeletedValueType) constructor.

• bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
Have the CodeOrigin(WTF::HashTableDeletedValueType) constructor
initialize the BytecodeIndex object accordingly, as a deleted value.
(JSC::CodeOrigin::isHashTableDeletedValue const):
Test BytecodeIndex object's deleted-value condition through the
corresponding BytecodeIndex::isHashTableDeletedValue() method.

• profiler/ProfilerOrigin.h:

(JSC::Profiler::Origin::Origin):
Simplify the m_bytecodeIndex member initialization for a deleted value.
(JSC::Profiler::Origin::operator! const):
Fix the negation operator, returning true if the m_bytecodeIndex is
either empty or deleted.

File:

• trunk/Source/JavaScriptCore/profiler/ProfilerOrigin.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/profiler/ProfilerOrigin.h

@@ -44 +44 @@
     Origin() = default;
     Origin(WTF::HashTableDeletedValueType)
-        : m_bytecodeIndex(BytecodeIndex(WTF::HashTableDeletedValue))
+        : m_bytecodeIndex(WTF::HashTableDeletedValue)
     { }
     
@@ -56 +56 @@
     Origin(Database&, CodeBlock*, BytecodeIndex);
     
-    bool operator!() const { return !!m_bytecodeIndex; }
+    bool operator!() const { return !m_bytecodeIndex; }
     
     Bytecodes* bytecodes() const { return m_bytecodes; }