Changeset 261464 in webkit for trunk/Source/JavaScriptCore/profiler

Timestamp:

May 10, 2020, 7:36:05 PM (5 years ago)

Author:

Ross Kirsling

Message:

[clang-tidy] Run modernize-use-nullptr over JSC
​https://bugs.webkit.org/show_bug.cgi?id=211706

Reviewed by Darin Adler.

• API/APICallbackFunction.h:
• API/JSAPIGlobalObject.h:
• API/JSBase.cpp:
• API/JSCallbackObjectFunctions.h:
• API/JSClassRef.cpp:
• API/JSContextRef.cpp:
• API/JSObjectRef.cpp:
• API/JSScriptRef.cpp:
• API/JSValueRef.cpp:
• API/JSWeakObjectMapRefPrivate.cpp:
• API/tests/ExecutionTimeLimitTest.cpp:
• API/tests/PingPongStackOverflowTest.cpp:
• assembler/AbstractMacroAssembler.h:
• assembler/CPU.cpp:
• bytecode/CodeBlock.cpp:
• bytecode/DeleteByIdVariant.cpp:
• bytecode/GetByIdVariant.cpp:
• bytecode/InByIdVariant.cpp:
• bytecode/InlineCallFrame.cpp:
• bytecode/LazyOperandValueProfile.cpp:
• bytecode/PutByIdVariant.cpp:
• bytecode/ValueProfile.h:
• bytecode/ValueRecovery.cpp:
• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:
• debugger/DebuggerScope.h:
• dfg/DFGAbstractValue.cpp:
• dfg/DFGAdjacencyList.h:
• dfg/DFGArgumentPosition.h:
• dfg/DFGArrayifySlowPathGenerator.h:
• dfg/DFGAvailability.h:
• dfg/DFGByteCodeParser.cpp:
• dfg/DFGCFGSimplificationPhase.cpp:
• dfg/DFGCPSRethreadingPhase.cpp:
• dfg/DFGCompilationKey.h:
• dfg/DFGConstantFoldingPhase.cpp:
• dfg/DFGDisassembler.cpp:
• dfg/DFGDoubleFormatState.h:
• dfg/DFGEdge.h:
• dfg/DFGFixupPhase.cpp:
• dfg/DFGFrozenValue.cpp:
• dfg/DFGGenerationInfo.h:
• dfg/DFGGraph.h:
• dfg/DFGInPlaceAbstractState.cpp:
• dfg/DFGIntegerCheckCombiningPhase.cpp:
• dfg/DFGLazyJSValue.cpp:
• dfg/DFGNode.h:
• dfg/DFGOSREntrypointCreationPhase.cpp:
• dfg/DFGOSRExit.cpp:
• dfg/DFGOperations.cpp:
• dfg/DFGSilentRegisterSavePlan.h:
• dfg/DFGSpeculativeJIT.cpp:
• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT64.cpp:
• dfg/DFGStructureAbstractValue.cpp:
• dfg/DFGTransition.cpp:
• dfg/DFGTypeCheckHoistingPhase.cpp:
• dfg/DFGWorklist.cpp:
• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLAvailableRecovery.h:
• ftl/FTLExitValue.cpp:
• ftl/FTLFormattedValue.h:
• ftl/FTLJITCode.cpp:
• ftl/FTLLink.cpp:
• ftl/FTLLowerDFGToB3.cpp:
• ftl/FTLLoweredNodeValue.h:
• ftl/FTLOSREntry.cpp:
• ftl/FTLOSRExitCompiler.cpp:
• ftl/FTLTypedPointer.h:
• ftl/FTLValueFromBlock.h:
• ftl/FTLValueRange.h:
• heap/GCSegmentedArray.h:
• heap/Handle.h:
• heap/HandleSet.h:
• heap/HandleTypes.h:
• heap/HeapSnapshotBuilder.cpp:
• heap/MarkedBlockInlines.h:
• heap/Strong.h:
• heap/WeakImpl.h:
• heap/WeakInlines.h:
• heap/WeakSet.cpp:
• heap/WeakSet.h:
• interpreter/CallFrame.cpp:
• interpreter/CallFrame.h:
• interpreter/Interpreter.cpp:
• interpreter/ProtoCallFrame.h:
• interpreter/StackVisitor.cpp:
• interpreter/StackVisitor.h:
• jit/AssemblyHelpers.h:
• jit/CCallHelpers.h:
• jit/JITCode.cpp:
• jit/JITOperations.cpp:
• jit/Repatch.cpp:
• jit/ThunkGenerators.cpp:
• jsc.cpp:
• llint/LLIntSlowPaths.cpp:
• parser/ASTBuilder.h:
• parser/Lexer.cpp:
• parser/Lexer.h:
• parser/Nodes.cpp:
• parser/Nodes.h:
• parser/Parser.cpp:
• parser/Parser.h:
• parser/ParserArena.cpp:
• parser/ParserArena.h:
• parser/ParserFunctionInfo.h:
• parser/SyntaxChecker.h:
• parser/UnlinkedSourceCode.h:
• profiler/ProfilerBytecodeSequence.cpp:
• profiler/ProfilerCompilation.cpp:
• profiler/ProfilerDatabase.cpp:
• profiler/ProfilerOSRExitSite.cpp:
• profiler/ProfilerOriginStack.cpp:
• runtime/ArgList.h:
• runtime/ArrayPrototype.cpp:
• runtime/ClonedArguments.cpp:
• runtime/CommonSlowPaths.cpp:
• runtime/Completion.h:
• runtime/DataView.h:
• runtime/DatePrototype.cpp:
• runtime/DirectEvalExecutable.cpp:
• runtime/DumpContext.cpp:
• runtime/FunctionExecutable.cpp:
• runtime/IndirectEvalExecutable.cpp:
• runtime/JSArray.cpp:
• runtime/JSArrayBufferView.cpp:
• runtime/JSCJSValue.cpp:
• runtime/JSCJSValueInlines.h:
• runtime/JSCell.cpp:
• runtime/JSDataView.cpp:
• runtime/JSDestructibleObject.h:
• runtime/JSFunction.cpp:
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalObject.h:
• runtime/JSONObject.cpp:
• runtime/JSObject.cpp:
• runtime/JSObject.h:
• runtime/JSScope.cpp:
• runtime/JSScope.h:
• runtime/LiteralParser.cpp:
• runtime/OptionsList.h:
• runtime/PropertyDescriptor.cpp:
• runtime/PropertyMapHashTable.h:
• runtime/PropertySlot.h:
• runtime/PutPropertySlot.h:
• runtime/RegExpMatchesArray.h:
• runtime/RegExpPrototype.cpp:
• runtime/StringPrototype.cpp:
• runtime/Structure.cpp:
• runtime/Structure.h:
• runtime/TestRunnerUtils.cpp:
• runtime/TypedArrayType.cpp:
• runtime/VM.cpp:
• runtime/Watchdog.cpp:
• runtime/Watchdog.h:
• runtime/WriteBarrier.h:
• testRegExp.cpp:
• tools/JSDollarVM.cpp:
• wasm/WasmSlowPaths.cpp:
• yarr/RegularExpression.h:
• yarr/YarrInterpreter.cpp:
• yarr/YarrJIT.cpp:
• yarr/YarrJIT.h:
• yarr/YarrPattern.cpp:
• yarr/YarrPattern.h:

Location:

trunk/Source/JavaScriptCore/profiler

Files:

• ProfilerBytecodeSequence.cpp (modified) (2 diffs)
• ProfilerCompilation.cpp (modified) (5 diffs)
• ProfilerDatabase.cpp (modified) (6 diffs)
• ProfilerOSRExitSite.cpp (modified) (1 diff)
• ProfilerOriginStack.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp

@@ -81 +81 @@
     VM& vm = globalObject->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);
-    JSArray* header = constructEmptyArray(globalObject, 0);
+    JSArray* header = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, void());
     for (unsigned i = 0; i < m_header.size(); ++i) {
@@ -89 +89 @@
     result->putDirect(vm, vm.propertyNames->header, header);
     
-    JSArray* sequence = constructEmptyArray(globalObject, 0);
+    JSArray* sequence = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, void());
     for (unsigned i = 0; i < m_sequence.size(); ++i) {

trunk/Source/JavaScriptCore/profiler/ProfilerCompilation.cpp

@@ -122 +122 @@
     result->putDirect(vm, vm.propertyNames->compilationKind, jsString(vm, String::fromUTF8(toCString(m_kind))));
     
-    JSArray* profiledBytecodes = constructEmptyArray(globalObject, 0);
+    JSArray* profiledBytecodes = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (unsigned i = 0; i < m_profiledBytecodes.size(); ++i) {
@@ -132 +132 @@
     result->putDirect(vm, vm.propertyNames->profiledBytecodes, profiledBytecodes);
     
-    JSArray* descriptions = constructEmptyArray(globalObject, 0);
+    JSArray* descriptions = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (unsigned i = 0; i < m_descriptions.size(); ++i) {
@@ -142 +142 @@
     result->putDirect(vm, vm.propertyNames->descriptions, descriptions);
     
-    JSArray* counters = constructEmptyArray(globalObject, 0);
+    JSArray* counters = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (auto it = m_counters.begin(), end = m_counters.end(); it != end; ++it) {
@@ -156 +156 @@
     result->putDirect(vm, vm.propertyNames->counters, counters);
     
-    JSArray* exitSites = constructEmptyArray(globalObject, 0);
+    JSArray* exitSites = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (unsigned i = 0; i < m_osrExitSites.size(); ++i) {
@@ -166 +166 @@
     result->putDirect(vm, vm.propertyNames->osrExitSites, exitSites);
     
-    JSArray* exits = constructEmptyArray(globalObject, 0);
+    JSArray* exits = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (unsigned i = 0; i < m_osrExits.size(); ++i) {

trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.cpp

@@ -46 +46 @@
     , m_vm(vm)
     , m_shouldSaveAtExit(false)
-    , m_nextRegisteredDatabase(0)
+    , m_nextRegisteredDatabase(nullptr)
 {
 }
@@ -103 +103 @@
     JSObject* result = constructEmptyObject(globalObject);
     
-    JSArray* bytecodes = constructEmptyArray(globalObject, 0);
+    JSArray* bytecodes = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (unsigned i = 0; i < m_bytecodes.size(); ++i) {
@@ -113 +113 @@
     result->putDirect(vm, vm.propertyNames->bytecodes, bytecodes);
     
-    JSArray* compilations = constructEmptyArray(globalObject, 0);
+    JSArray* compilations = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (unsigned i = 0; i < m_compilations.size(); ++i) {
@@ -123 +123 @@
     result->putDirect(vm, vm.propertyNames->compilations, compilations);
     
-    JSArray* events = constructEmptyArray(globalObject, 0);
+    JSArray* events = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (unsigned i = 0; i < m_events.size(); ++i) {
@@ -200 +200 @@
             continue;
         *current = m_nextRegisteredDatabase;
-        m_nextRegisteredDatabase = 0;
+        m_nextRegisteredDatabase = nullptr;
         m_shouldSaveAtExit = false;
         break;
@@ -218 +218 @@
     if (result) {
         firstDatabase = result->m_nextRegisteredDatabase;
-        result->m_nextRegisteredDatabase = 0;
+        result->m_nextRegisteredDatabase = nullptr;
         result->m_shouldSaveAtExit = false;
     }

trunk/Source/JavaScriptCore/profiler/ProfilerOSRExitSite.cpp

@@ -39 +39 @@
     VM& vm = globalObject->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);
-    JSArray* result = constructEmptyArray(globalObject, 0);
+    JSArray* result = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });
     for (unsigned i = 0; i < m_codeAddresses.size(); ++i) {

trunk/Source/JavaScriptCore/profiler/ProfilerOriginStack.cpp

@@ -103 +103 @@
     VM& vm = globalObject->vm();
     auto scope = DECLARE_THROW_SCOPE(vm);
-    JSArray* result = constructEmptyArray(globalObject, 0);
+    JSArray* result = constructEmptyArray(globalObject, nullptr);
     RETURN_IF_EXCEPTION(scope, { });